All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Henningsson <david.henningsson@canonical.com>
To: Bjorn Helgaas <bhelgaas@google.com>
Cc: "linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>
Subject: Re: [PATCH] Add pci=assign-busses quirk to Dell Latitude D505
Date: Fri, 29 Aug 2014 16:44:33 +0200	[thread overview]
Message-ID: <540091D1.1040902@canonical.com> (raw)
In-Reply-To: <CAErSpo5v82xeYGqsiWXpfQdr8kF9x+1K4gjYremfCh3fNQ8Unw@mail.gmail.com>



On 2014-08-29 16:22, Bjorn Helgaas wrote:
> On Fri, Aug 29, 2014 at 3:10 AM, David Henningsson
> <david.henningsson@canonical.com> wrote:
>> Under a 3.16 based kernel (Ubuntu 3.16.0-031600-lowlatency),
>> CardBus is not working unless pci=assign-buses is added to the
>> kernel boot parameters.
>>
>> Signed-off-by: David Henningsson <david.henningsson@canonical.com>
>> ---
>>   arch/x86/pci/common.c | 8 ++++++++
>>   1 file changed, 8 insertions(+)
>>
>> It was working OOTB on a 3.2 based kernel (Ubuntu 3.2.0-67-generic),
>> and I have not thoroughly bisected what made it stop working.
>> Still I'm suggesting to just a quirk to make it work regardless of
>> kernel - it's a ~8 year old laptop, so being a bit lazy about it is
>> probably okay, I hope. :-)
>
> Please open a bugzilla and attach complete "lspci -vv" output and
> dmesg logs from the working 3.2 kernel and a non-working current
> kernel.
>
> The quirk might be OK, but it would be better if we could make a
> generic fix that would work on more machines than just this one.

All right, you can now find the requested information in this bug:

https://bugzilla.kernel.org/show_bug.cgi?id=83441

>
>>
>> Extract from dmidecode:
>>
>> Handle 0x0100, DMI type 1, 25 bytes
>> System Information
>>          Manufacturer: Dell Inc.
>>          Product Name: Latitude D505
>>
>> diff --git a/arch/x86/pci/common.c b/arch/x86/pci/common.c
>> index 059a76c..1849e39 100644
>> --- a/arch/x86/pci/common.c
>> +++ b/arch/x86/pci/common.c
>> @@ -262,6 +262,14 @@ static const struct dmi_system_id pciprobe_dmi_table[] = {
>>                          DMI_MATCH(DMI_PRODUCT_NAME, "SX20S"),
>>                  },
>>          },
>> +       {
>> +               .callback = assign_all_busses,
>> +               .ident = "Dell Latitude D505 Laptop",
>> +               .matches = {
>> +                       DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
>> +                       DMI_MATCH(DMI_PRODUCT_NAME, "Latitude D505"),
>> +               },
>> +       },
>>   #endif         /* __i386__ */
>>          {
>>                  .callback = set_bf_sort,
>> --
>> 1.9.1
>>
>

-- 
David Henningsson, Canonical Ltd.
https://launchpad.net/~diwic

  reply	other threads:[~2014-08-29 14:44 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-29  9:10 [PATCH] Add pci=assign-busses quirk to Dell Latitude D505 David Henningsson
2014-08-29 14:22 ` Bjorn Helgaas
2014-08-29 14:44   ` David Henningsson [this message]
2014-08-29 17:36     ` Bjorn Helgaas
2014-09-10 18:08       ` Bjorn Helgaas
2014-09-10 19:50         ` Andreas Noever
2014-09-10 20:37           ` Bjorn Helgaas
2014-09-11  8:13         ` David Henningsson
2014-09-13  3:18           ` Bjorn Helgaas
2014-09-14 22:10             ` Andreas Noever
2014-09-15  9:53               ` Wei Yang
2014-09-15 10:04                 ` Andreas Noever
2014-09-16  1:37                   ` Wei Yang
2014-09-16  3:00                     ` Gavin Shan
2014-09-15 19:03                 ` Bjorn Helgaas
2014-09-16  8:49                   ` Wei Yang
2014-09-19 17:04             ` Bjorn Helgaas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=540091D1.1040902@canonical.com \
    --to=david.henningsson@canonical.com \
    --cc=bhelgaas@google.com \
    --cc=linux-pci@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.