Re: [Qemu-devel] [PATCH v2] curl: Allow a cookie or cookies to be sent with http/https requests.

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1645 bytes --]

On 08/29/2014 09:03 AM, Richard W.M. Jones wrote:
> In order to access VMware ESX efficiently, we need to send a session
> cookie.  This patch is very simple and just allows you to send that
> session cookie.  It punts on the question of how you get the session
> cookie in the first place, but in practice you can just run a `curl'
> command against the server and extract the cookie that way.
> 

> +++ b/qemu-options.hx
> @@ -2351,6 +2351,11 @@ multiple of 512 bytes. It defaults to 256k.
>  @item sslverify
>  Whether to verify the remote server's certificate when connecting over SSL. It
>  can have the value 'on' or 'off'. It defaults to 'on'.
> +
> +@item cookie
> +Send this cookie (it can also be a list of cookies separated by ';') with
> +each outgoing request.  Only supported when using protocols such as HTTP
> +which support cookies, otherwise ignored.

';' has to be quoted to enter it in the shell command line (but then
again, the cookie probably contains literal " which also has to be quoted).

We still don't have a QMP mapping for curl device hotplug.  But when we
gain one, do we really want to have a single (long) string containing
multiple cookies, or would it be better to make this an array argument?
 On the command-line, which is nicer, taking the cookie option multiple
times ('file.cookie=xyz,file.cookie.abc'), taking it as an automatic
array ('file.cookie.0=xyz,file.cookie.1=abc') or forcing the user to
cram all cookies into a single option ('file.cookie="xyz;abc"')?

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 539 bytes --]