From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1XNP4D-0007If-Pj for mharc-qemu-trivial@gnu.org; Fri, 29 Aug 2014 12:30:25 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46613) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XNP46-00078y-Qe for qemu-trivial@nongnu.org; Fri, 29 Aug 2014 12:30:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XNP40-0002f9-Is for qemu-trivial@nongnu.org; Fri, 29 Aug 2014 12:30:18 -0400 Received: from isrv.corpit.ru ([86.62.121.231]:43845) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XNP3o-0002CC-2j; Fri, 29 Aug 2014 12:30:00 -0400 Received: from [192.168.88.2] (mjt.vpn.tls.msk.ru [192.168.177.99]) by isrv.corpit.ru (Postfix) with ESMTP id 628F24583B; Fri, 29 Aug 2014 20:29:59 +0400 (MSK) Message-ID: <5400AA87.5000904@msgid.tls.msk.ru> Date: Fri, 29 Aug 2014 20:29:59 +0400 From: Michael Tokarev Organization: Telecom Service, JSC User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Icedove/24.7.0 MIME-Version: 1.0 To: Chen Fan , qemu-devel@nongnu.org, qemu-trivial@nongnu.org References: In-Reply-To: X-Enigmail-Version: 1.6 OpenPGP: id=804465C5 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 86.62.121.231 Subject: Re: [Qemu-trivial] [RESEND v2 0/3] Fix some memory leaks about query memdev X-BeenThere: qemu-trivial@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 Aug 2014 16:30:25 -0000 18.08.2014 10:46, Chen Fan wrote: > when using valgrind to test the command "query memdev", I had > found some memory leaks. the test result: ... Applied all 3 to -trivial. Usually these are not really trivial. Please note that your 2nd patch - "qom/object.c: fix string_output_get_string() memory leak" - also touches hmp.c (which has a maintainer), but you didn't mention this in patch description. I've added it. Thanks, /mjt From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46557) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XNP3u-0006x6-Dn for qemu-devel@nongnu.org; Fri, 29 Aug 2014 12:30:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XNP3o-0002Cv-9H for qemu-devel@nongnu.org; Fri, 29 Aug 2014 12:30:06 -0400 Message-ID: <5400AA87.5000904@msgid.tls.msk.ru> Date: Fri, 29 Aug 2014 20:29:59 +0400 From: Michael Tokarev MIME-Version: 1.0 References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [Qemu-trivial] [RESEND v2 0/3] Fix some memory leaks about query memdev List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Chen Fan , qemu-devel@nongnu.org, qemu-trivial@nongnu.org 18.08.2014 10:46, Chen Fan wrote: > when using valgrind to test the command "query memdev", I had > found some memory leaks. the test result: ... Applied all 3 to -trivial. Usually these are not really trivial. Please note that your 2nd patch - "qom/object.c: fix string_output_get_string() memory leak" - also touches hmp.c (which has a maintainer), but you didn't mention this in patch description. I've added it. Thanks, /mjt