From: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
To: Jeff King <peff@peff.net>
Cc: Junio C Hamano <gitster@pobox.com>,
GIT Mailing-list <git@vger.kernel.org>
Subject: [PATCH] builtin/commit.c: fix type warnings from gcc and sparse
Date: Fri, 29 Aug 2014 17:36:21 +0100 [thread overview]
Message-ID: <5400AC05.9060900@ramsay1.demon.co.uk> (raw)
On 32-bit platforms (only), gcc and sparse both issue warnings
about the type of the pointer expression passed as the third
argument to find_commit_header(). In order to suppress the
warnings, we simply change the type of the 'len' variable to
size_t.
Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
---
Hi Jeff,
If you need to re-roll your 'jk/commit-author-parsing' series, could
you please squash this into the equivalent of commit 95b5989
("determine_author_info(): reuse parsing functions", 27-08-2014).
Thanks!
ATB,
Ramsay Jones
builtin/commit.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/builtin/commit.c b/builtin/commit.c
index a9bef73..7cb9981 100644
--- a/builtin/commit.c
+++ b/builtin/commit.c
@@ -583,7 +583,7 @@ static void determine_author_info(struct strbuf *author_ident)
if (author_message) {
struct ident_split ident;
- unsigned long len;
+ size_t len;
const char *a;
a = find_commit_header(author_message_buffer, "author", &len);
--
2.1.0
next reply other threads:[~2014-08-29 16:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-29 16:36 Ramsay Jones [this message]
2014-08-29 18:44 ` [PATCH] builtin/commit.c: fix type warnings from gcc and sparse Jeff King
2014-08-29 22:17 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5400AC05.9060900@ramsay1.demon.co.uk \
--to=ramsay@ramsay1.demon.co.uk \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.