From: Casey Schaufler <casey@schaufler-ca.com>
To: Lukasz Pawelczyk <l.pawelczyk@samsung.com>,
r.krypa@samsung.com, havner@gmail.com, m.lis@samsung.com,
"Serge E. Hallyn" <serge@hallyn.com>,
James Morris <james.l.morris@oracle.com>,
linux-kernel@vger.kernel.org,
linux-security-module@vger.kernel.org
Cc: Casey Schaufler <casey@schaufler-ca.com>
Subject: Re: [PATCH 1/3] Small fixes in comments describing function parameters
Date: Fri, 29 Aug 2014 10:19:04 -0700 [thread overview]
Message-ID: <5400B608.1070507@schaufler-ca.com> (raw)
In-Reply-To: <1409324575-12057-1-git-send-email-l.pawelczyk@samsung.com>
On 8/29/2014 8:02 AM, Lukasz Pawelczyk wrote:
> Signed-off-by: Lukasz Pawelczyk <l.pawelczyk@samsung.com>
Applied to git://git.gitorious.org/smack-next/kernel.git#smack-for-3.18
> ---
> security/smack/smack_lsm.c | 18 +++++++++---------
> 1 file changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/security/smack/smack_lsm.c b/security/smack/smack_lsm.c
> index 154548e..478d99e 100644
> --- a/security/smack/smack_lsm.c
> +++ b/security/smack/smack_lsm.c
> @@ -771,8 +771,8 @@ static void smack_inode_free_security(struct inode *inode)
>
> /**
> * smack_inode_init_security - copy out the smack from an inode
> - * @inode: the inode
> - * @dir: unused
> + * @inode: the newly created inode
> + * @dir: containing directory object
> * @qstr: unused
> * @name: where to put the attribute name
> * @value: where to put the attribute value
> @@ -923,10 +923,10 @@ static int smack_inode_rmdir(struct inode *dir, struct dentry *dentry)
>
> /**
> * smack_inode_rename - Smack check on rename
> - * @old_inode: the old directory
> - * @old_dentry: unused
> - * @new_inode: the new directory
> - * @new_dentry: unused
> + * @old_inode: unused
> + * @old_dentry: the old object
> + * @new_inode: unused
> + * @new_dentry: the new object
> *
> * Read and write access is required on both the old and
> * new directories.
> @@ -1017,7 +1017,7 @@ static int smack_inode_setattr(struct dentry *dentry, struct iattr *iattr)
>
> /**
> * smack_inode_getattr - Smack check for getting attributes
> - * @mnt: unused
> + * @mnt: vfsmount of the object
> * @dentry: the object
> *
> * Returns 0 if access is permitted, an error code otherwise
> @@ -1042,8 +1042,8 @@ static int smack_inode_getattr(struct vfsmount *mnt, struct dentry *dentry)
> * smack_inode_setxattr - Smack check for setting xattrs
> * @dentry: the object
> * @name: name of the attribute
> - * @value: unused
> - * @size: unused
> + * @value: value of the attribute
> + * @size: size of the value
> * @flags: unused
> *
> * This protects the Smack attribute explicitly.
prev parent reply other threads:[~2014-08-29 17:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-29 15:02 [PATCH 1/3] Small fixes in comments describing function parameters Lukasz Pawelczyk
2014-08-29 15:02 ` [PATCH 2/3] Fix a bidirectional UDS connect check typo Lukasz Pawelczyk
2014-08-29 17:19 ` Casey Schaufler
2014-08-29 15:02 ` [PATCH 3/3] Make Smack operate on smack_known struct where it still used char* Lukasz Pawelczyk
2014-08-29 17:20 ` Casey Schaufler
2014-08-29 17:19 ` Casey Schaufler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5400B608.1070507@schaufler-ca.com \
--to=casey@schaufler-ca.com \
--cc=havner@gmail.com \
--cc=james.l.morris@oracle.com \
--cc=l.pawelczyk@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=m.lis@samsung.com \
--cc=r.krypa@samsung.com \
--cc=serge@hallyn.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.