From: Julien Grall <julien.grall@linaro.org>
To: Arianna Avanzini <avanzini.arianna@gmail.com>
Cc: julien.grall@citrix.com, paolo.valente@unimore.it, keir@xen.org,
stefano.stabellini@eu.citrix.com, tim@xen.org,
dario.faggioli@citrix.com, Ian.Jackson@eu.citrix.com,
xen-devel@lists.xen.org, Ian.Campbell@eu.citrix.com,
etrudeau@broadcom.com, JBeulich@suse.com,
andrew.cooper3@citrix.com, viktor.kleinik@globallogic.com,
andrii.tseglytskyi@globallogic.com
Subject: Re: [PATCH v11 02/14] arch/arm: unmap partially-mapped memory regions
Date: Fri, 29 Aug 2014 15:19:22 -0400 [thread overview]
Message-ID: <5400D23A.3070403@linaro.org> (raw)
In-Reply-To: <20140828091902.GA862@gmail.com>
On 28/08/14 05:19, Arianna Avanzini wrote:
> On Wed, Aug 27, 2014 at 12:35:54PM -0400, Julien Grall wrote:
>> Hi Arianna,
>
> Hello!
Hi Arianna,
> Thank you for the correction and for pointing that corner case out. Since I
> have to send a new version perhaps I'll try to handle also the case you
> mentioned. Just to see if I understood things correctly: the correct behavior
> would be to leave the mapping already existing at the end of the range as it
> is?
The main point is too unmap only what you have mapped during the call of
apply_p2m_changes.
Otherwise you may get spurious warning message on Xen console and/or
remove mapping that you haven't mapped.
But, for the latter case the mapping would have been override if the
call was succeeded.
Regards,
--
Julien Grall
next prev parent reply other threads:[~2014-08-29 19:19 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-24 20:29 [PATCH v11 00/14] Implement the XEN_DOMCTL_memory_mapping hypercall for ARM Arianna Avanzini
2014-08-24 20:29 ` [PATCH v11 01/14] arch/arm: add consistency check to REMOVE p2m changes Arianna Avanzini
2014-08-27 14:46 ` Julien Grall
2014-08-24 20:29 ` [PATCH v11 02/14] arch/arm: unmap partially-mapped memory regions Arianna Avanzini
2014-08-27 16:35 ` Julien Grall
2014-08-28 9:19 ` Arianna Avanzini
2014-08-29 19:19 ` Julien Grall [this message]
2014-08-24 20:29 ` [PATCH v11 03/14] arch/x86: warn if to-be-removed mapping does not exist Arianna Avanzini
2014-08-24 20:29 ` [PATCH v11 04/14] arch/x86: cleanup memory_mapping DOMCTL Arianna Avanzini
2014-08-24 20:29 ` [PATCH v11 05/14] xen/common: add ARM stub for the function memory_type_changed() Arianna Avanzini
2014-08-24 20:29 ` [PATCH v11 06/14] xen/x86: factor out map and unmap from the memory_mapping DOMCTL Arianna Avanzini
2014-08-24 20:30 ` [PATCH v11 07/14] xen/common: move the memory_mapping DOMCTL hypercall to common code Arianna Avanzini
2014-08-24 20:30 ` [PATCH v11 08/14] tools/libxl: parse optional start gfn from the iomem config option Arianna Avanzini
2014-08-24 20:30 ` [PATCH v11 09/14] tools/libxl: handle the iomem parameter with the memory_mapping hcall Arianna Avanzini
2014-08-24 20:30 ` [PATCH v11 10/14] xsm/flask: avoid spurious error messages when mapping I/O-memory Arianna Avanzini
2014-08-27 16:40 ` Julien Grall
2014-08-24 20:30 ` [PATCH v11 11/14] flask/policy: allow domU to use previously-mapped I/O-memory Arianna Avanzini
2014-08-24 20:30 ` [PATCH v11 12/14] tools/libxl: explicitly grant access to needed I/O-memory ranges Arianna Avanzini
2014-08-24 20:30 ` [PATCH v11 13/14] tools/libxl: cleanup the do_pci_add() function Arianna Avanzini
2014-08-24 20:30 ` [PATCH v11 14/14] xen/common: do not implicitly permit access to mapped I/O memory Arianna Avanzini
2014-08-29 13:41 ` [PATCH v11 00/14] Implement the XEN_DOMCTL_memory_mapping hypercall for ARM Andrii Tseglytskyi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5400D23A.3070403@linaro.org \
--to=julien.grall@linaro.org \
--cc=Ian.Campbell@eu.citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=andrii.tseglytskyi@globallogic.com \
--cc=avanzini.arianna@gmail.com \
--cc=dario.faggioli@citrix.com \
--cc=etrudeau@broadcom.com \
--cc=julien.grall@citrix.com \
--cc=keir@xen.org \
--cc=paolo.valente@unimore.it \
--cc=stefano.stabellini@eu.citrix.com \
--cc=tim@xen.org \
--cc=viktor.kleinik@globallogic.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.