From: Michael Schmitz <schmitzmic@gmail.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: linux-m68k@lists.linux-m68k.org
Subject: Re: [PATCH] USB: isp116x: isa_rom_*() calls should depend on CONFIG_ATARI_ROM_ISA
Date: Sat, 30 Aug 2014 13:25:02 +1200 [thread overview]
Message-ID: <540127EE.7080900@gmail.com> (raw)
In-Reply-To: <1409328966-10079-1-git-send-email-geert@linux-m68k.org>
Hi Geert,
that's certainly correct - the EtherNAT version of the USB driver didn't
need the ROM accessors but the version including NetUSBee support does
for sure.
Thanks!
Ack'ed-by: Michael Schmitz <schmitzmic@gmail.com>
> If CONFIG_ATARI_ROM_ISA=n:
>
> drivers/usb/host/isp116x.h: In function ‘isp116x_write_addr’:
> drivers/usb/host/isp116x.h:382: error: implicit declaration of function ‘isa_rom_writew_raw’
> drivers/usb/host/isp116x.h: In function ‘isp116x_raw_write_data16’:
> drivers/usb/host/isp116x.h:394: error: implicit declaration of function ‘isa_rom_writew’
> drivers/usb/host/isp116x.h: In function ‘isp116x_read_data16’:
> drivers/usb/host/isp116x.h:402: error: implicit declaration of function ‘isa_rom_readw_raw’
> drivers/usb/host/isp116x.h: In function ‘isp116x_raw_read_data16’:
> drivers/usb/host/isp116x.h:411: error: implicit declaration of function ‘isa_rom_readw’
>
> The isa_rom_*() calls should depend on CONFIG_ATARI_ROM_ISA instead of
> on CONFIG_ATARI.
>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> ---
> To be folded into "m68k/atari: USB - add ISP1160 USB host controller
> support"
> ---
> drivers/usb/host/isp116x.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/host/isp116x.h b/drivers/usb/host/isp116x.h
> index c436f55f2882..634258df159b 100644
> --- a/drivers/usb/host/isp116x.h
> +++ b/drivers/usb/host/isp116x.h
> @@ -355,7 +355,7 @@ struct isp116x_ep {
> #endif
>
>
> -#ifdef CONFIG_ATARI
> +#ifdef CONFIG_ATARI_ROM_ISA
> /*
> * 16 bit data bus byte swapped in hardware on both Atari variants.
> * EtherNAT variant of ISP1160 integration is memory mapped at 0x800000XX,
next prev parent reply other threads:[~2014-08-30 1:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-29 16:16 [PATCH] USB: isp116x: isa_rom_*() calls should depend on CONFIG_ATARI_ROM_ISA Geert Uytterhoeven
2014-08-30 1:25 ` Michael Schmitz [this message]
2014-09-08 7:45 ` Geert Uytterhoeven
2014-09-08 8:47 ` Michael Schmitz
2014-09-08 9:04 ` Geert Uytterhoeven
2014-09-09 8:33 ` Michael Schmitz
2014-09-09 8:38 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=540127EE.7080900@gmail.com \
--to=schmitzmic@gmail.com \
--cc=geert@linux-m68k.org \
--cc=linux-m68k@lists.linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.