From: "Torsten Bögershausen" <tboegi@web.de>
To: "Junio C Hamano" <gitster@pobox.com>,
"Torsten Bögershausen" <tboegi@web.de>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 1/2] t0027: Tests for core.eol=native, eol=lf, eol=crlf
Date: Sat, 30 Aug 2014 11:01:03 +0200 [thread overview]
Message-ID: <540192CF.7070407@web.de> (raw)
In-Reply-To: <xmqqha0wa09z.fsf@gitster.dls.corp.google.com>
On 2014-08-28 21.20, Junio C Hamano wrote:
> It appears that I missed this patch? You seem to have rerolled the
> corresponding 2/2, to which I responded ($gmane/255507). Is this
> one still viable/necessary?
It seems that both the t0027 and the native_crlf fixes (from MINGW)
deserve a re-roll from my side, so you didn't miss anything.
Thanks for the comments below
>
> If you are doing the whole-sale style fixes for this script, can you
> also fix the case/esac statement in create_gitattributes? The case
> arm labels are indented one level too deep, making it harder to spot
> them than necessary.
>
> Test files "setup master" step creates appear to end in an
> incomplete line. Is this intended or by mistake? Making sure
> things work even on files that end in an incomplete line is a good
> thing, but it looks somewhat strange not to test normal cases (in
> other words, it makes it appear as if normal cases work OK but
> incomplete lines cause corner case bugs and these tests are meant to
> check them, or something).
>
> Thanks.
prev parent reply other threads:[~2014-08-30 9:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-16 20:16 [PATCH 1/2] t0027: Tests for core.eol=native, eol=lf, eol=crlf Torsten Bögershausen
2014-08-28 19:20 ` Junio C Hamano
2014-08-30 9:01 ` Torsten Bögershausen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=540192CF.7070407@web.de \
--to=tboegi@web.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.