From: "Charlie Davies" <charles.davies@whitetree.xyz>
To: bitbake-devel@lists.openembedded.org
Subject: Re: [bitbake][dunfell][1.46][PATCH 1/2] bitbake: fetch/git: add support for SRC_URI containing spaces in url
Date: Tue, 13 Oct 2020 14:44:48 -0700 [thread overview]
Message-ID: <5402.1602625488617192663@lists.openembedded.org> (raw)
In-Reply-To: <CAOSpxdZ-L_YBuB+urokrTuLNKdLBhnrc7xY41ubh_p03ZVxzSw@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 360 bytes --]
Thank you for the feedback Enrico.
I agree that using shlex.quote() is a better method to implement this functionality.
I have written a patch using shlex.quote() instead of escaped double quotes. I will run this patch through my local setup tonight before submitting in the morning.
Steve, I will submit against master, dunfell and 1.46.
Charlie
[-- Attachment #2: Type: text/html, Size: 392 bytes --]
next prev parent reply other threads:[~2020-10-13 21:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-12 15:07 [bitbake][dunfell][1.46][PATCH 0/2] Patch review Steve Sakoman
2020-10-12 15:07 ` [bitbake][dunfell][1.46][PATCH 1/2] bitbake: fetch/git: add support for SRC_URI containing spaces in url Steve Sakoman
2020-10-13 10:51 ` [bitbake-devel] " Enrico Scholz
2020-10-13 18:20 ` Steve Sakoman
2020-10-13 21:44 ` Charlie Davies [this message]
2020-10-12 15:07 ` [bitbake][dunfell][1.46][PATCH 2/2] bitbake: tests/fetch: add unit tests for SRC_URI with " Steve Sakoman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5402.1602625488617192663@lists.openembedded.org \
--to=charles.davies@whitetree.xyz \
--cc=bitbake-devel@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.