Re: [PATCH envytools] nvbios: Fix reading of ram_restrict_group_count.

[Martin Peres <martin.peres-GANU6spQydw@public.gmane.org>]

On 30/08/2014 19:05, Christian Costa wrote:
> The entry offset was use instead of the data it points to. Probably a regression.
> The files showing script parsing errors has been reduced from 410 to 6 with the database of 505 vbios.
> ---
>   nvbios/mem.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/nvbios/mem.c b/nvbios/mem.c
> index 81f2d1b..e4797e3 100644
> --- a/nvbios/mem.c
> +++ b/nvbios/mem.c
> @@ -232,11 +232,11 @@ envy_bios_parse_bit_M (struct envy_bios *bios, struct envy_bios_bit_entry *bit)
>   
>   	if (bit->version == 1) {
>   		if (bit->t_len >= 5) {
> -			bios_u8(bios, bit->offset+2, &ram_restrict_group_count);
> +			bios_u8(bios, bit->t_offset+2, &ram_restrict_group_count);
>   		}
>   	} else if (bit->version == 2) {
>   		if (bit->t_len >= 3) {
> -			bios_u8(bios, bit->offset, &ram_restrict_group_count);
> +			bios_u8(bios, bit->t_offset, &ram_restrict_group_count);
>   		}
>   	}
>   

A very big thank you Christian for this fix! It had been bothering a few 
of us but we never really
looked into it because we always was reminded of this bug while doing 
something else.

I pushed all three patches! Looking forward to seeing what's next ;)