Re: [PATCH envytools] nvbios: Add missing null byte to string read from file.

[Martin Peres <martin.peres-GANU6spQydw@public.gmane.org>]

On 31/08/2014 15:00, Christian Costa wrote:
> ---
>   nvbios/nvbios.c | 5 +++--
>   1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/nvbios/nvbios.c b/nvbios/nvbios.c
> index f7aafe3..28e62ad 100644
> --- a/nvbios/nvbios.c
> +++ b/nvbios/nvbios.c
> @@ -774,11 +774,12 @@ int set_strap_from_string(const char* strap_s)
>   int set_strap_from_file(const char *path)
>   {
>   	FILE *strapfile = NULL;
> -	char tmp[21];
> +	char tmp[22];
>   
>   	strapfile = fopen(path, "r");
>   	if (strapfile) {
> -		fread(tmp, 1, 21, strapfile);
> +		size_t size = fread(tmp, 1, 21, strapfile);
> +		tmp[size] = 0;
>   		return set_strap_from_string(tmp);
>   	}
>   
Thanks, I pushed the first 3 patches!