From mboxrd@z Thu Jan 1 00:00:00 1970 From: inki.dae@samsung.com (Inki Dae) Date: Mon, 01 Sep 2014 11:47:41 +0900 Subject: [PATCH RFC v2 3/8] component: add support for component match array In-Reply-To: <20140830213349.GE30401@n2100.arm.linux.org.uk> References: <20140624192830.GC20555@n2100.arm.linux.org.uk> <20140626144601.GS32514@n2100.arm.linux.org.uk> <20140701142210.GS32514@n2100.arm.linux.org.uk> <20140830213349.GE30401@n2100.arm.linux.org.uk> Message-ID: <5403DE4D.3090509@samsung.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 2014? 08? 31? 06:33, Russell King - ARM Linux wrote: > On Thu, Jul 03, 2014 at 12:26:39AM +0900, Inki Dae wrote: >> 2014-07-01 23:22 GMT+09:00 Russell King - ARM Linux : >>> On Thu, Jun 26, 2014 at 03:46:01PM +0100, Russell King - ARM Linux wrote: >>>> On Thu, Jun 26, 2014 at 02:34:17PM +0200, Philipp Zabel wrote: >>>>> Hi Russell, >>>>> >>>>> On Tue, Jun 24, 2014 at 9:29 PM, Russell King >>>>> wrote: >>>>> [...] >>>>>> +/* >>>>>> + * Add a component to be matched. >>>>>> + * >>>>>> + * The match array is first created or extended if necessary. >>>>>> + */ >>>>>> +void component_match_add(struct device *dev, struct component_match **matchptr, >>>>>> + int (*compare)(struct device *, void *), void *compare_data) >>>>>> +{ >>>>>> + struct component_match *match = *matchptr; >>>>>> + >>>>>> + if (IS_ERR(match)) >>>>>> + return; >>>>>> + >>>>>> + if (!match || match->num == match->alloc) { >>>>>> + size_t new_size = match ? match->alloc + 16 : 15; >>>>>> + >>>>>> + match = component_match_realloc(dev, match, new_size); >>>>>> + >>>>>> + *matchptr = match; >>>>>> + >>>>>> + if (IS_ERR(match)) >>>>>> + return; >>>>>> + } >>>>>> + >>>>>> + match->compare[match->num].fn = compare; >>>>>> + match->compare[match->num].data = compare_data; >>>>>> + match->num++; >>>>>> +} >>>>> >>>>> component_match_add should be exported. >>>> >>>> Fixed, thanks. >>> >>> As there's no further comments, and Inki Dae has not responded, I'm >> >> It's has been just a week. I will check and look into your patch >> series. I think Exynos drm should also be considered for the use of >> component match array. > > It has now been almost two months. What's happening on this? > > Please note that I'm planning to push the rest of the component updates > during the next merge window, which will result in unconverted drivers > breaking. > Sorry for this. I was busy with other works. I will update and post it until this week. Thanks, Inki Dae > Thanks. > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Inki Dae Subject: Re: [PATCH RFC v2 3/8] component: add support for component match array Date: Mon, 01 Sep 2014 11:47:41 +0900 Message-ID: <5403DE4D.3090509@samsung.com> References: <20140624192830.GC20555@n2100.arm.linux.org.uk> <20140626144601.GS32514@n2100.arm.linux.org.uk> <20140701142210.GS32514@n2100.arm.linux.org.uk> <20140830213349.GE30401@n2100.arm.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mailout3.samsung.com (mailout3.samsung.com [203.254.224.33]) by gabe.freedesktop.org (Postfix) with ESMTP id DDC446E1BD for ; Sun, 31 Aug 2014 19:47:50 -0700 (PDT) Received: from epcpsbgr3.samsung.com (u143.gpu120.samsung.co.kr [203.254.230.143]) by mailout3.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0NB7003SFBRPDN30@mailout3.samsung.com> for dri-devel@lists.freedesktop.org; Mon, 01 Sep 2014 11:47:49 +0900 (KST) In-reply-to: <20140830213349.GE30401@n2100.arm.linux.org.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Russell King - ARM Linux Cc: devel@driverdev.osuosl.org, linux-arm-kernel , dri-devel@lists.freedesktop.org, Laurent Pinchart List-Id: dri-devel@lists.freedesktop.org T24gMjAxNOuFhCAwOOyblCAzMeydvCAwNjozMywgUnVzc2VsbCBLaW5nIC0gQVJNIExpbnV4IHdy b3RlOgo+IE9uIFRodSwgSnVsIDAzLCAyMDE0IGF0IDEyOjI2OjM5QU0gKzA5MDAsIElua2kgRGFl IHdyb3RlOgo+PiAyMDE0LTA3LTAxIDIzOjIyIEdNVCswOTowMCBSdXNzZWxsIEtpbmcgLSBBUk0g TGludXggPGxpbnV4QGFybS5saW51eC5vcmcudWs+Ogo+Pj4gT24gVGh1LCBKdW4gMjYsIDIwMTQg YXQgMDM6NDY6MDFQTSArMDEwMCwgUnVzc2VsbCBLaW5nIC0gQVJNIExpbnV4IHdyb3RlOgo+Pj4+ IE9uIFRodSwgSnVuIDI2LCAyMDE0IGF0IDAyOjM0OjE3UE0gKzAyMDAsIFBoaWxpcHAgWmFiZWwg d3JvdGU6Cj4+Pj4+IEhpIFJ1c3NlbGwsCj4+Pj4+Cj4+Pj4+IE9uIFR1ZSwgSnVuIDI0LCAyMDE0 IGF0IDk6MjkgUE0sIFJ1c3NlbGwgS2luZwo+Pj4+PiA8cm1rK2tlcm5lbEBhcm0ubGludXgub3Jn LnVrPiB3cm90ZToKPj4+Pj4gWy4uLl0KPj4+Pj4+ICsvKgo+Pj4+Pj4gKyAqIEFkZCBhIGNvbXBv bmVudCB0byBiZSBtYXRjaGVkLgo+Pj4+Pj4gKyAqCj4+Pj4+PiArICogVGhlIG1hdGNoIGFycmF5 IGlzIGZpcnN0IGNyZWF0ZWQgb3IgZXh0ZW5kZWQgaWYgbmVjZXNzYXJ5Lgo+Pj4+Pj4gKyAqLwo+ Pj4+Pj4gK3ZvaWQgY29tcG9uZW50X21hdGNoX2FkZChzdHJ1Y3QgZGV2aWNlICpkZXYsIHN0cnVj dCBjb21wb25lbnRfbWF0Y2ggKiptYXRjaHB0ciwKPj4+Pj4+ICsgICAgICAgaW50ICgqY29tcGFy ZSkoc3RydWN0IGRldmljZSAqLCB2b2lkICopLCB2b2lkICpjb21wYXJlX2RhdGEpCj4+Pj4+PiAr ewo+Pj4+Pj4gKyAgICAgICBzdHJ1Y3QgY29tcG9uZW50X21hdGNoICptYXRjaCA9ICptYXRjaHB0 cjsKPj4+Pj4+ICsKPj4+Pj4+ICsgICAgICAgaWYgKElTX0VSUihtYXRjaCkpCj4+Pj4+PiArICAg ICAgICAgICAgICAgcmV0dXJuOwo+Pj4+Pj4gKwo+Pj4+Pj4gKyAgICAgICBpZiAoIW1hdGNoIHx8 IG1hdGNoLT5udW0gPT0gbWF0Y2gtPmFsbG9jKSB7Cj4+Pj4+PiArICAgICAgICAgICAgICAgc2l6 ZV90IG5ld19zaXplID0gbWF0Y2ggPyBtYXRjaC0+YWxsb2MgKyAxNiA6IDE1Owo+Pj4+Pj4gKwo+ Pj4+Pj4gKyAgICAgICAgICAgICAgIG1hdGNoID0gY29tcG9uZW50X21hdGNoX3JlYWxsb2MoZGV2 LCBtYXRjaCwgbmV3X3NpemUpOwo+Pj4+Pj4gKwo+Pj4+Pj4gKyAgICAgICAgICAgICAgICptYXRj aHB0ciA9IG1hdGNoOwo+Pj4+Pj4gKwo+Pj4+Pj4gKyAgICAgICAgICAgICAgIGlmIChJU19FUlIo bWF0Y2gpKQo+Pj4+Pj4gKyAgICAgICAgICAgICAgICAgICAgICAgcmV0dXJuOwo+Pj4+Pj4gKyAg ICAgICB9Cj4+Pj4+PiArCj4+Pj4+PiArICAgICAgIG1hdGNoLT5jb21wYXJlW21hdGNoLT5udW1d LmZuID0gY29tcGFyZTsKPj4+Pj4+ICsgICAgICAgbWF0Y2gtPmNvbXBhcmVbbWF0Y2gtPm51bV0u ZGF0YSA9IGNvbXBhcmVfZGF0YTsKPj4+Pj4+ICsgICAgICAgbWF0Y2gtPm51bSsrOwo+Pj4+Pj4g K30KPj4+Pj4KPj4+Pj4gY29tcG9uZW50X21hdGNoX2FkZCBzaG91bGQgYmUgZXhwb3J0ZWQuCj4+ Pj4KPj4+PiBGaXhlZCwgdGhhbmtzLgo+Pj4KPj4+IEFzIHRoZXJlJ3Mgbm8gZnVydGhlciBjb21t ZW50cywgYW5kIElua2kgRGFlIGhhcyBub3QgcmVzcG9uZGVkLCBJJ20KPj4KPj4gSXQncyBoYXMg YmVlbiBqdXN0IGEgd2Vlay4gSSB3aWxsIGNoZWNrIGFuZCBsb29rIGludG8geW91ciBwYXRjaAo+ PiBzZXJpZXMuIEkgdGhpbmsgRXh5bm9zIGRybSBzaG91bGQgYWxzbyBiZSBjb25zaWRlcmVkIGZv ciB0aGUgdXNlIG9mCj4+IGNvbXBvbmVudCBtYXRjaCBhcnJheS4KPiAKPiBJdCBoYXMgbm93IGJl ZW4gYWxtb3N0IHR3byBtb250aHMuICBXaGF0J3MgaGFwcGVuaW5nIG9uIHRoaXM/Cj4gCj4gUGxl YXNlIG5vdGUgdGhhdCBJJ20gcGxhbm5pbmcgdG8gcHVzaCB0aGUgcmVzdCBvZiB0aGUgY29tcG9u ZW50IHVwZGF0ZXMKPiBkdXJpbmcgdGhlIG5leHQgbWVyZ2Ugd2luZG93LCB3aGljaCB3aWxsIHJl c3VsdCBpbiB1bmNvbnZlcnRlZCBkcml2ZXJzCj4gYnJlYWtpbmcuCj4gCgpTb3JyeSBmb3IgdGhp cy4gSSB3YXMgYnVzeSB3aXRoIG90aGVyIHdvcmtzLiBJIHdpbGwgdXBkYXRlIGFuZCBwb3N0IGl0 CnVudGlsIHRoaXMgd2Vlay4KClRoYW5rcywKSW5raSBEYWUKCj4gVGhhbmtzLgo+IAoKX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxp bmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVl ZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK