From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53840) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XOOVD-0006yy-Sa for qemu-devel@nongnu.org; Mon, 01 Sep 2014 06:06:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XOOV1-0001Uc-3B for qemu-devel@nongnu.org; Mon, 01 Sep 2014 06:06:23 -0400 Received: from e06smtp12.uk.ibm.com ([195.75.94.108]:38683) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XOOV0-0001UB-R2 for qemu-devel@nongnu.org; Mon, 01 Sep 2014 06:06:11 -0400 Received: from /spool/local by e06smtp12.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 1 Sep 2014 11:06:08 +0100 Received: from b06cxnps4074.portsmouth.uk.ibm.com (d06relay11.portsmouth.uk.ibm.com [9.149.109.196]) by d06dlp03.portsmouth.uk.ibm.com (Postfix) with ESMTP id 433321B08061 for ; Mon, 1 Sep 2014 11:07:06 +0100 (BST) Received: from d06av08.portsmouth.uk.ibm.com (d06av08.portsmouth.uk.ibm.com [9.149.37.249]) by b06cxnps4074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id s81A66w846268646 for ; Mon, 1 Sep 2014 10:06:06 GMT Received: from d06av08.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av08.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id s81A65vp007935 for ; Mon, 1 Sep 2014 04:06:06 -0600 Message-ID: <5404450C.1070409@de.ibm.com> Date: Mon, 01 Sep 2014 12:06:04 +0200 From: Christian Borntraeger MIME-Version: 1.0 References: <1409320338-63098-1-git-send-email-jfrei@linux.vnet.ibm.com> In-Reply-To: <1409320338-63098-1-git-send-email-jfrei@linux.vnet.ibm.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 0/5] s390x/gdb: various fixes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jens Freimann , Alexander Graf , Cornelia Huck Cc: Alexey Kardashevskiy , Peter Maydell , qemu-devel@nongnu.org On 29/08/14 15:52, Jens Freimann wrote: > Conny, Alex, Christian, > > here are some patches improving our gdb support. > > * Patch 1 fixes a bug where the cc was changed accidentally. > * Patch 2 adds the gdb feature XML files for s390x > * Patch 3 Define acr and fpr registers as coprocessor registers. This allows us > to reuse the feature XML files. > * Patch 4 whitespace fixes > * Patch 5 changes common code and other architectures with gdb target.xml support. > It adds a field gdb_arch_name to the XML description of the CPU and to struct > CPUClass. It allows the remote gdb to detect the target architecture > in cases where it can't tell otherwise. > > David Hildenbrand (5): > s390x/gdb: don't touch the cc if tcg is not enabled > s390x/gdb: add the feature xml files for s390x > s390x/gdb: generate target.xml and handle fp/ac as coprocessors > s390x/gdb: coding style fixes > gdb: provide the name of the architecture in the target.xml > > configure | 1 + > gdb-xml/s390-acr.xml | 26 +++++++++++ > gdb-xml/s390-fpr.xml | 27 +++++++++++ > gdb-xml/s390x-core64.xml | 28 ++++++++++++ > gdbstub.c | 19 +++++--- > include/qom/cpu.h | 2 + > target-arm/cpu64.c | 1 + > target-ppc/translate_init.c | 2 + > target-s390x/cpu-qom.h | 1 + > target-s390x/cpu.c | 5 +- > target-s390x/cpu.h | 40 +--------------- > target-s390x/gdbstub.c | 109 +++++++++++++++++++++++++++++++++----------- > 12 files changed, 188 insertions(+), 73 deletions(-) > create mode 100644 gdb-xml/s390-acr.xml > create mode 100644 gdb-xml/s390-fpr.xml > create mode 100644 gdb-xml/s390x-core64.xml > Applied 1-4. Peter, do you want to push patch5 yourself? As an alternative I can push it via the s390 tree, I need your ACK in that case. Alex, (or Alexey?) can you ACK/NACK patch 5 from the power perspective?