From mboxrd@z Thu Jan  1 00:00:00 1970
From: Don Slutz <dslutz@verizon.com>
Subject: Re: [PATCH v2 0/3] Xen VMware tools support
Date: Mon, 01 Sep 2014 14:14:11 -0400
Message-ID: <5404B773.6000108@terremark.com>
References: <1409585629-25840-1-git-send-email-dslutz@verizon.com>
	<5404B6A1020000780002F915@mail.emea.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <5404B6A1020000780002F915@mail.emea.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>
Cc: Tim Deegan <tim@xen.org>, Kevin Tian <kevin.tian@intel.com>, Keir Fraser <keir@xen.org>, Ian Campbell <ian.campbell@citrix.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>, Jun Nakajima <jun.nakajima@intel.com>, Andrew Cooper <andrew.cooper3@citrix.com>, Ian Jackson <ian.jackson@eu.citrix.com>, Don Slutz <dslutz@verizon.com>, xen-devel@lists.xen.org, Eddie Dong <eddie.dong@intel.com>, Aravind Gopalakrishnan <Aravind.Gopalakrishnan@amd.com>, Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>, Boris Ostrovsky <boris.ostrovsky@oracle.com>
List-Id: xen-devel@lists.xenproject.org


On 09/01/14 12:10, Jan Beulich wrote:
>>>> On 01.09.14 at 17:33, <dslutz@verizon.com> wrote:
>> changes RFC to v2:
>>
>> Jan Beulich:
>>    Add xen/arch/x86/hvm/vmware.c for cpuid_vmware_leaves
>>    Fewer patches
>> [...]
>>   xen/arch/x86/hvm/vmport/Makefile             |    1 +
>>   xen/arch/x86/hvm/vmport/backdoor_def.h       |  167 +++
>>   xen/arch/x86/hvm/vmport/guest_msg_def.h      |   87 ++
>>   xen/arch/x86/hvm/vmport/includeCheck.h       |   17 +
>>   xen/arch/x86/hvm/vmport/vmport.c             | 1436 ++++++++++++++++++++++++++
>>   xen/arch/x86/hvm/vmware.c                    |   85 ++
> I don't think you should be adding a new fine in hvm/ _and_ a
> new subdirectory. If VMware support requires more than one
> file, everything should probably go into hvm/vmware/.

Sure.
    -Don Slutz


> Jan
>