All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eli Billauer <eli.billauer@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: gregkh@linuxfoundation.org, arnd@arndb.de,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: xillybus: Move out of staging
Date: Mon, 01 Sep 2014 21:55:18 +0300	[thread overview]
Message-ID: <5404C116.9020300@gmail.com> (raw)
In-Reply-To: <20140901121318.GG5122@mwanda>

Hello, Dan.

Thanks a lot for reviewing the driver. There are indeed a few things 
that need fixing. I'll be back with patches and responses in a matter of 
a few days.

As for the --strict option, I wasn't aware of it. I learn something new 
every time. :)

Thanks again,
    Eli

On 01/09/14 15:13, Dan Carpenter wrote:
> Pretty nice.  This is very special purpose hardware and the UAPI for
> this is fine.  The documentation seems good.  I had some minor style
> comments but nothing major stands out.
>
> These days I quite like the --strict option for checkpatch.pl.
>
> for i in $(find drivers/staging/xillybus/ -name \*\.c)
> 	do ./scripts/checkpatch.pl --strict -f $i
> done
>
>    


  parent reply	other threads:[~2014-09-01 19:11 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-31  7:57 [PATCH] staging: xillybus: Move out of staging Eli Billauer
2014-09-01 12:13 ` Dan Carpenter
2014-09-01 13:08   ` Arend van Spriel
2014-09-02 10:23     ` Eli Billauer
2014-09-01 17:22   ` Joe Perches
2014-09-01 18:55   ` Eli Billauer [this message]
2014-09-04 15:23   ` Eli Billauer
2014-09-01 12:33 ` Tobias Klauser
2014-09-01 19:01   ` Eli Billauer
2014-09-01 19:12     ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5404C116.9020300@gmail.com \
    --to=eli.billauer@gmail.com \
    --cc=arnd@arndb.de \
    --cc=dan.carpenter@oracle.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.