From: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>
To: rafael.j.wysocki@intel.com
Cc: mika.westerberg@linux.intel.com, rafael@kernel.org,
linux-acpi@vger.kernel.org
Subject: Question of " 202317a : ACPI / scan: Add acpi_device objects for all device nodes in the namespace" commit
Date: Tue, 2 Sep 2014 10:53:09 +0900 [thread overview]
Message-ID: <54052305.9060308@jp.fujitsu.com> (raw)
Hi Rafael,
Why is _SUN method decoded and the sun sysfs created even if _STA reports
that the device is not present and not functional?
By this commit, "202317a : ACPI / scan: Add acpi_device objects for all
device nodes in the namespace", all device nodes in the namespace are
shown under /sys/bus/acpi/devices direcotry even if the devices are not
present and not functional.
But ACPI specification says against return value information of _STA:
A device can only decode its hardware resources if both bits 0 and 1 are set.
If the device is not present (bit 0 cleared) or not enabled (bit 1 cleared),
then the device must not decode its resources.
In my understanding, when the device is not present and not functional,
_SUN of the device must not be decoded. Is my understanding worng?
In our box, when the device is not present and not functional, _SUN method
of the device returns wrong value. And the values is cached to
acpi_device->pnp.sun. So when hot adding the device and changing _SUN value,
the information is not reflected to acpi_device->pnp.sun.
I think the issue is solved by not caching sun value. But at first, I want
to know whether current implementation is correct or not.
Thanks,
Yasuaki Ishimatsu
next reply other threads:[~2014-09-02 2:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-02 1:53 Yasuaki Ishimatsu [this message]
2014-09-02 21:29 ` Question of " 202317a : ACPI / scan: Add acpi_device objects for all device nodes in the namespace" commit Rafael J. Wysocki
2014-09-03 2:14 ` Yasuaki Ishimatsu
2014-09-03 4:39 ` [PATCH] acpi : not caching sun value in acpi_device_pnp Yasuaki Ishimatsu
2014-09-03 21:41 ` Rafael J. Wysocki
2014-09-03 23:45 ` Yasuaki Ishimatsu
2014-09-03 21:45 ` Question of " 202317a : ACPI / scan: Add acpi_device objects for all device nodes in the namespace" commit Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54052305.9060308@jp.fujitsu.com \
--to=isimatu.yasuaki@jp.fujitsu.com \
--cc=linux-acpi@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=rafael.j.wysocki@intel.com \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.