Re: [PATCH 1/1] piglit: enable ptest support

[Robert Yang <liezhi.yang@windriver.com>]

On 09/02/2014 10:14 AM, Robert Yang wrote:
>
>
> On 08/28/2014 10:09 PM, Burton, Ross wrote:
>> On 18 August 2014 06:39, Chong Lu <Chong.Lu@windriver.com> wrote:
>>> +env PIGLIT_BUILD_DIR=`pwd`/.. piglit-run.py `pwd`/tests/sanity.tests
>>> `pwd`/results/sanity.results 2>&1
>>
>> You shouldn't need to set PIGLIT_BUILD_DIR.
>>
>> The sanity tests are very basic so this won't count as "running
>> piglit" in any meaningful QA sense.
>>
>>> @@ -36,7 +37,6 @@ do_install() {
>>>          cp -Pr lib/ ${D}${libdir}/piglit/
>>>          cp -Pr framework/ ${D}${libdir}/piglit/
>>>          cp -Pr generated_tests/ ${D}${libdir}/piglit/
>>> -       cp -Pr tests/ ${D}${libdir}/piglit/
>>>          cp -Pr templates/ ${D}${libdir}/piglit/
>>>
>>>          sed -i -e
>>> 's|sys.path.append(.*)|sys.path.append("${libdir}/piglit")|'
>>> ${D}${bindir}/piglit-*.py
>>> @@ -46,3 +46,7 @@ do_install() {
>>>   FILES_${PN}-dbg += "${libdir}/piglit/*/.debug/"
>>>
>>>   RDEPENDS_${PN} = "python waffle python-json python-subprocess
>>> python-multiprocessing python-textutils python-netserver python-shell
>>> mesa-demos"
>>> +
>>> +do_install_ptest() {
>>> +       cp -Pr tests/ ${D}${PTEST_PATH}/
>>> +}
>>
>> Why move the tests directory to the -ptests package?  That makes
>> piglit unusable without installing piglit-ptest.
>
> Hello, if we keep the tests dir in piglit, shall we add perl to

Sorry, bash, in fact.

// Robert

> the RDEPENDS ? There are perl scripts in the tests dir.
>
> // Robert
>
>>
>> I agree that piglit should be ptest-enabled, but the piglit-ptest
>> package should simply depend on piglit and contain the runner script.
>>
>> Ross
>>