All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Mack <zonque@gmail.com>
To: Klaus Goger <klaus.goger@theobroma-systems.com>,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Input: cap1106 - fix register definition
Date: Tue, 02 Sep 2014 09:43:34 +0200	[thread overview]
Message-ID: <54057526.9050503@gmail.com> (raw)
In-Reply-To: <1409639544-30420-1-git-send-email-klaus.goger@theobroma-systems.com>

On 09/02/2014 08:32 AM, Klaus Goger wrote:
> Use the correct register address for Calibration Active and Interrupt
> Enable
> 
> Signed-off-by: Klaus Goger <klaus.goger@theobroma-systems.com>

These register definitions are currently unused, but your fix is
correct. Just curious - are you planning to send patches that make use
of them?

  Acked-by: Daniel Mack <zonque@gmail.com>


Thanks,
Daniel

> ---
>  drivers/input/keyboard/cap1106.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/input/keyboard/cap1106.c b/drivers/input/keyboard/cap1106.c
> index 180b184..d70b65a 100644
> --- a/drivers/input/keyboard/cap1106.c
> +++ b/drivers/input/keyboard/cap1106.c
> @@ -33,8 +33,8 @@
>  #define CAP1106_REG_SENSOR_CONFIG	0x22
>  #define CAP1106_REG_SENSOR_CONFIG2	0x23
>  #define CAP1106_REG_SAMPLING_CONFIG	0x24
> -#define CAP1106_REG_CALIBRATION		0x25
> -#define CAP1106_REG_INT_ENABLE		0x26
> +#define CAP1106_REG_CALIBRATION		0x26
> +#define CAP1106_REG_INT_ENABLE		0x27
>  #define CAP1106_REG_REPEAT_RATE		0x28
>  #define CAP1106_REG_MT_CONFIG		0x2a
>  #define CAP1106_REG_MT_PATTERN_CONFIG	0x2b
> 


  reply	other threads:[~2014-09-02  7:43 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-02  6:32 [PATCH] Input: cap1106 - fix register definition Klaus Goger
2014-09-02  7:43 ` Daniel Mack [this message]
2014-09-02 11:01   ` Klaus Goger
2014-09-08 21:46     ` Dmitry Torokhov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54057526.9050503@gmail.com \
    --to=zonque@gmail.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=klaus.goger@theobroma-systems.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.