All of lore.kernel.org
 help / color / mirror / Atom feed
From: Phil Kauffman <kauffman@cs.uchicago.edu>
To: neilb@suse.de
Cc: linux-raid@vger.kernel.org
Subject: mdadm patch Monitor.c
Date: Tue, 02 Sep 2014 13:12:05 -0500	[thread overview]
Message-ID: <54060875.3070403@cs.uchicago.edu> (raw)

[-- Attachment #1: Type: text/plain, Size: 1016 bytes --]

Neil,

Hopefully, you are still the maintainer of mdadm.
I would like to request the following trivial patch... pretty please!

--- Monitor.c	2014-08-21 05:16:56.000000000 -0500
+++ Monitor.c.new	2014-09-02 13:03:45.106590425 -0500
@@ -402,14 +402,12 @@
  			if (disc && disc[0] == ' ')
  				fprintf(mp, "Extra information:%s.\n\n", disc);

-			fprintf(mp, "Faithfully yours, etc.\n");
-
  			mdstat = fopen("/proc/mdstat", "r");
  			if (mdstat) {
  				char buf[8192];
  				int n;
  				fprintf(mp,
-					"\nP.S. The /proc/mdstat file"
+					"\nThe /proc/mdstat file"
  					" currently contains the following:\n\n");
  				while ( (n=fread(buf, 1, sizeof(buf), mdstat)) > 0)
  					n=fwrite(buf, 1, n, mp);


The words removed above are superfluous and add no value to the message. 
In addition, they imply that the message is from a person, which is 
obviously not the case.

Cheers,

Phil


-- 
Phil Kauffman
Systems Admin
Dept. of Computer Science
University of Chicago
kauffman@cs.uchicago.edu
773-702-3913

[-- Attachment #2: Monitor.c.patch --]
[-- Type: text/x-patch, Size: 575 bytes --]

--- Monitor.c	2014-08-21 05:16:56.000000000 -0500
+++ Monitor.c.new	2014-09-02 13:03:45.106590425 -0500
@@ -402,14 +402,12 @@
 			if (disc && disc[0] == ' ')
 				fprintf(mp, "Extra information:%s.\n\n", disc);
 
-			fprintf(mp, "Faithfully yours, etc.\n");
-
 			mdstat = fopen("/proc/mdstat", "r");
 			if (mdstat) {
 				char buf[8192];
 				int n;
 				fprintf(mp,
-					"\nP.S. The /proc/mdstat file"
+					"\nThe /proc/mdstat file"
 					" currently contains the following:\n\n");
 				while ( (n=fread(buf, 1, sizeof(buf), mdstat)) > 0)
 					n=fwrite(buf, 1, n, mp);

                 reply	other threads:[~2014-09-02 18:12 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54060875.3070403@cs.uchicago.edu \
    --to=kauffman@cs.uchicago.edu \
    --cc=linux-raid@vger.kernel.org \
    --cc=neilb@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.