From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1XOsvY-00005j-Tr for mharc-qemu-trivial@gnu.org; Tue, 02 Sep 2014 14:35:37 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48199) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XOsvQ-0008RO-8k for qemu-trivial@nongnu.org; Tue, 02 Sep 2014 14:35:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XOsvK-0003d5-K3 for qemu-trivial@nongnu.org; Tue, 02 Sep 2014 14:35:28 -0400 Received: from isrv.corpit.ru ([86.62.121.231]:38057) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XOsv8-0003Jq-Rf; Tue, 02 Sep 2014 14:35:11 -0400 Received: from [192.168.88.2] (mjt.vpn.tls.msk.ru [192.168.177.99]) by isrv.corpit.ru (Postfix) with ESMTP id 0722B405CF; Tue, 2 Sep 2014 22:35:01 +0400 (MSK) Message-ID: <54060DD5.4020903@msgid.tls.msk.ru> Date: Tue, 02 Sep 2014 22:35:01 +0400 From: Michael Tokarev Organization: Telecom Service, JSC User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Icedove/24.7.0 MIME-Version: 1.0 To: Peter Maydell , QEMU Developers References: <1402933670-3324-1-git-send-email-peter.maydell@linaro.org> In-Reply-To: X-Enigmail-Version: 1.6 OpenPGP: id=804465C5 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 86.62.121.231 Cc: QEMU Trivial , Jan Kiszka , Patch Tracking Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] slirp: Honour vlan/stack in hostfwd_remove commands X-BeenThere: qemu-trivial@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Sep 2014 18:35:34 -0000 26.06.2014 16:35, Peter Maydell wrote: > On 16 June 2014 16:47, Peter Maydell wrote: >> The hostfwd_add and hostfwd_remove monitor commands allow the user >> to optionally specify a vlan/stack tuple. hostfwd_add honours this, >> but hostfwd_remove does not (it looks up the tuple but then ignores >> the SlirpState it has looked up and always uses the first stack >> in the list anyway). Correct this to honour what the user requested. I've applied this to -trivial. Somehow this patch has been marked as "handled" in my queue, but actually it weren't - that's why I haven't really seen the pings. Thanks, /mjt From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48145) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XOsvF-0008G0-1M for qemu-devel@nongnu.org; Tue, 02 Sep 2014 14:35:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XOsv9-0003aJ-9a for qemu-devel@nongnu.org; Tue, 02 Sep 2014 14:35:16 -0400 Message-ID: <54060DD5.4020903@msgid.tls.msk.ru> Date: Tue, 02 Sep 2014 22:35:01 +0400 From: Michael Tokarev MIME-Version: 1.0 References: <1402933670-3324-1-git-send-email-peter.maydell@linaro.org> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [Qemu-trivial] [PATCH] slirp: Honour vlan/stack in hostfwd_remove commands List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell , QEMU Developers Cc: QEMU Trivial , Jan Kiszka , Patch Tracking 26.06.2014 16:35, Peter Maydell wrote: > On 16 June 2014 16:47, Peter Maydell wrote: >> The hostfwd_add and hostfwd_remove monitor commands allow the user >> to optionally specify a vlan/stack tuple. hostfwd_add honours this, >> but hostfwd_remove does not (it looks up the tuple but then ignores >> the SlirpState it has looked up and always uses the first stack >> in the list anyway). Correct this to honour what the user requested. I've applied this to -trivial. Somehow this patch has been marked as "handled" in my queue, but actually it weren't - that's why I haven't really seen the pings. Thanks, /mjt