From: pekon <pekon@pek-sem.com>
To: Roger Quadros <rogerq@ti.com>, tony@atomide.com
Cc: linux-omap@vger.kernel.org
Subject: Re: [PATCH 5/6] ARM: OMAP2+: gpmc: Don't complain if wait pin is used without r/w monitoring
Date: Wed, 03 Sep 2014 00:42:32 +0530 [thread overview]
Message-ID: <540616A0.9040900@pek-sem.com> (raw)
In-Reply-To: <1409666227-20622-6-git-send-email-rogerq@ti.com>
On Tuesday 02 September 2014 07:27 PM, Roger Quadros wrote:
> For NAND read & write wait pin monitoring must be kept disabled as the
> wait pin is only used to indicate NAND device ready status and not to
> extend each read/write cycle.
>
I think this description, does not fit in this patch.
And is incorrect as explained in previous patch review.
> So don't print a warning if wait pin is specified while read/write
> monitoring is not in the device tree.
>
> Sanity check wait pin number irrespective if read/write monitoring is
> set or not.
>
> Signed-off-by: Roger Quadros <rogerq@ti.com>
> ---
But below mentioned checks and clean-up makes sense. So
apart from first 3 lines of commit log ..
Reviewed-by: Pekon Gupta <pekon@pek-sem.com>
with regards, pekon
------------------------
Powered by BigRock.com
next prev parent reply other threads:[~2014-09-02 19:12 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-02 13:57 [PATCH 0/6] OMAP2+: GPMC: NAND fixes for 3.17 Roger Quadros
2014-09-02 13:57 ` [PATCH 1/6] ARM: dts: am43x-epos-evm: Use BCH16 ECC scheme instead of BCH8 Roger Quadros
2014-09-02 18:29 ` pekon
2014-09-02 13:57 ` [PATCH 2/6] ARM: dts: am437x-gp-evm: " Roger Quadros
2014-09-02 18:30 ` pekon
2014-09-02 13:57 ` [PATCH 3/6] ARM: dts: am437x-gp-evm: Don't use read/write wait monitoring Roger Quadros
2014-09-02 19:02 ` pekon
2014-09-03 8:32 ` Roger Quadros
2014-09-03 8:32 ` Roger Quadros
2014-09-03 17:29 ` pekon
2014-09-03 17:29 ` pekon
2014-09-04 9:46 ` Roger Quadros
2014-09-04 18:57 ` pekon
2014-09-04 18:57 ` pekon
2014-09-02 13:57 ` [PATCH 4/6] ARM: dts: am43xx-epos-evm: " Roger Quadros
2014-09-02 13:57 ` [PATCH 5/6] ARM: OMAP2+: gpmc: Don't complain if wait pin is used without r/w monitoring Roger Quadros
2014-09-02 19:12 ` pekon [this message]
2014-09-03 8:34 ` Roger Quadros
2014-09-02 13:57 ` [PATCH 6/6] ARM: dts: am43x-epos-evm: Disable QSPI to prevent conflict with GPMC-NAND Roger Quadros
2014-09-02 18:09 ` [PATCH 0/6] OMAP2+: GPMC: NAND fixes for 3.17 pekon
2014-09-03 21:40 ` Tony Lindgren
2014-09-03 21:42 ` Tony Lindgren
2014-09-04 19:00 ` pekon
2014-09-04 19:40 ` Tony Lindgren
2014-09-05 7:57 ` Roger Quadros
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=540616A0.9040900@pek-sem.com \
--to=pekon@pek-sem.com \
--cc=linux-omap@vger.kernel.org \
--cc=rogerq@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.