From: Tom Lendacky <thomas.lendacky@amd.com>
To: David Miller <davem@davemloft.net>
Cc: <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next v1 0/3] amd-xgbe: AMD XGBE driver updates 2014-08-29
Date: Tue, 2 Sep 2014 14:55:49 -0500 [thread overview]
Message-ID: <540620C5.2070906@amd.com> (raw)
In-Reply-To: <20140901.203152.216310411574954349.davem@davemloft.net>
On 09/01/2014 10:31 PM, David Miller wrote:
> From: Tom Lendacky <thomas.lendacky@amd.com>
> Date: Fri, 29 Aug 2014 10:21:48 -0500
>
>> The amd-xgbe-phy phylib driver support is integral to the amd-xgbe
>> driver and isn't meant to be used by other devices. For this reason
>> it is being removed from the driver/net/phy directory and integrated
>> into the amd-xgbe driver.
>
> I see no real reason to do this.
>
> Keeping it in the phylib layer forces you to deal with the abstractions
> and therefore keeps you from bypassing the phylib API and performing
> layer violations.
>
> Please just keep the PHY driver where it is and add your new features
> there.
Ok, understood. I'll drop this patch series. Any future changes or
enhancements will apply against the established file locations.
Thanks,
Tom
>
> Thanks.
>
prev parent reply other threads:[~2014-09-02 19:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-29 15:21 [PATCH net-next v1 0/3] amd-xgbe: AMD XGBE driver updates 2014-08-29 Tom Lendacky
2014-08-29 15:21 ` [PATCH net-next v1 1/3] amd-xgbe: Move phy driver support into the network driver Tom Lendacky
2014-08-29 15:22 ` [PATCH net-next v1 2/3] amd-xgbe: Move the phy device resources into network device Tom Lendacky
2014-08-29 15:22 ` [PATCH net-next v1 3/3] amd-xgbe: Enhance auto-negotiation parallel detection Tom Lendacky
2014-09-02 3:31 ` [PATCH net-next v1 0/3] amd-xgbe: AMD XGBE driver updates 2014-08-29 David Miller
2014-09-02 19:55 ` Tom Lendacky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=540620C5.2070906@amd.com \
--to=thomas.lendacky@amd.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.