Re: [PATCH] ASoC: tlv320aic31xx: place codec into reset state initially

["Peter S. Housel" <housel@acm.org>]

Ping...

Thanks,
-Peter-

On 08/05/2014 12:34 AM, Jyri Sarha wrote:
> On 08/05/2014 01:13 AM, Peter S. Housel wrote:
>> Previously the driver would only place the TLV320AIC31XX into reset
>> using the gpio reset line when at least one of the power supply
>> regulators was disabled, so that if these supplies were always enabled
>> no reset would ever occur. This change resets the codec state at probe
>> time so that the initial register cache values are correct.
>>
>> Signed-off-by: Peter S. Housel <housel@acm.org>
>> ---
>>   sound/soc/codecs/tlv320aic31xx.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/sound/soc/codecs/tlv320aic31xx.c 
>> b/sound/soc/codecs/tlv320aic31xx.c
>> index 0f64c78..89a4daf 100644
>> --- a/sound/soc/codecs/tlv320aic31xx.c
>> +++ b/sound/soc/codecs/tlv320aic31xx.c
>> @@ -1194,7 +1194,7 @@ static int aic31xx_device_init(struct 
>> aic31xx_priv *aic31xx)
>>       if (aic31xx->pdata.gpio_reset) {
>>           ret = devm_gpio_request_one(aic31xx->dev,
>>                           aic31xx->pdata.gpio_reset,
>> -                        GPIOF_OUT_INIT_HIGH,
>> +                        GPIOF_OUT_INIT_LOW,
>>                           "aic31xx-reset-pin");
>>           if (ret < 0) {
>>               dev_err(aic31xx->dev, "not able to acquire gpio\n");
>>
>
> Oops, aic3111 and friends indeed have an active low reset line. The 
> line was not behind a gpio on my board.
>
> Acked-by: Jyri Sarha <jsarha@ti.com>
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel