From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41571) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XOyrz-0001Vt-Vp for qemu-devel@nongnu.org; Tue, 02 Sep 2014 20:56:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XOyrv-0006Hk-5h for qemu-devel@nongnu.org; Tue, 02 Sep 2014 20:56:19 -0400 Message-ID: <54066718.2060103@huawei.com> Date: Wed, 3 Sep 2014 08:55:52 +0800 From: zhanghailiang MIME-Version: 1.0 References: <1409284371-7396-1-git-send-email-zhang.zhanghailiang@huawei.com> In-Reply-To: <1409284371-7396-1-git-send-email-zhang.zhanghailiang@huawei.com> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH V2] acpi-build: Set FORCE_APIC_CLUSTER_MODEL bit for FADT flags List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "qemu-devel@nongnu.org" Cc: mst@redhat.com, luonengjun@huawei.com, peter.huangpeng@huawei.com, qemu-stable@nongnu.org, huangzhichao , aliguori@amazon.com Hi, Ping... Thanks, zhanghailiang On 2014/8/29 11:52, zhanghailiang wrote: > If we start Windows 2008 R2 DataCenter with number of cpu less than 8, > The system will use APIC Flat Logical destination mode as default configuration, > Which has an upper limit of 8 CPUs. > > The fault is that VM can not show all processors within Task Manager if > we hot-add cpus when the number of cpus in VM extends the limit of 8. > > If we use cluster destination model, the problem will be solved. > > Signed-off-by: huangzhichao > Signed-off-by: zhanghailiang > --- > v2: > - Set this bit when max_cpus> 8 > --- > hw/i386/acpi-build.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c > index 85e5834..cdc3b08 100644 > --- a/hw/i386/acpi-build.c > +++ b/hw/i386/acpi-build.c > @@ -550,6 +550,12 @@ static void fadt_setup(AcpiFadtDescriptorRev1 *fadt, AcpiPmInfo *pm) > (1<< ACPI_FADT_F_SLP_BUTTON) | > (1<< ACPI_FADT_F_RTC_S4)); > fadt->flags |= cpu_to_le32(1<< ACPI_FADT_F_USE_PLATFORM_CLOCK); > + /* APIC destination mode ("Flat Logical") has an upper limit of 8 CPUs > + * For more than 8 CPUs, "Clustered Logical" mode has to be used > + */ > + if (max_cpus> 8) { > + fadt->flags |= cpu_to_le32(1<< ACPI_FADT_F_FORCE_APIC_CLUSTER_MODEL); > + } > } > >