From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43190) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XP6dP-0006qL-1l for qemu-devel@nongnu.org; Wed, 03 Sep 2014 05:13:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XP6dH-0008OV-CD for qemu-devel@nongnu.org; Wed, 03 Sep 2014 05:13:46 -0400 Received: from cantor2.suse.de ([195.135.220.15]:39368 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XP6dH-0008OA-54 for qemu-devel@nongnu.org; Wed, 03 Sep 2014 05:13:39 -0400 Message-ID: <5406DBC0.6070704@suse.de> Date: Wed, 03 Sep 2014 11:13:36 +0200 From: Alexander Graf MIME-Version: 1.0 References: <1409733914-1272-1-git-send-email-eric.auger@linaro.org> In-Reply-To: <1409733914-1272-1-git-send-email-eric.auger@linaro.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC] vfio: migration to trace points List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Auger , eric.auger@st.com, christoffer.dall@linaro.org, qemu-devel@nongnu.org, kim.phillips@freescale.com, a.rigo@virtualopensystems.com, aik@ozlabs.ru, bsd@redhat.com, pbonzini@redhat.com, kraxel@redhat.com, stefanha@redhat.com, peter.maydell@linaro.org Cc: Bharat.Bhushan@freescale.com, alex.williamson@redhat.com, patches@linaro.org, kvmarm@lists.cs.columbia.edu, stuart.yoder@freescale.com On 03.09.14 10:45, Eric Auger wrote: > This patch removes all DPRINTF and replace them by trace points. > A few DPRINTF used in error cases were transformed into error_report. > > Signed-off-by: Eric Auger > > --- > > - __func__ is removed since trace point name does the same job > - HWADDR_PRIx were replaced by PRIx64 > > Besides those changes format strings were kept the same. in few > cases however I was forced to change them due to parsing errors > (always related to parenthesis handling). This is indicated in > trace-events. Cases than are not correctly handled are given below: > - "(%04x:%02x:%02x.%x)" need to be replaced by " (%04x:%02x:%02x.%x)" > - "%s read(%04x:%02x:%02x.%x:BAR%d+0x%"PRIx64", %d) = 0x%"PRIx64 -> > "%s read(%04x:%02x:%02x.%x:BAR%d+0x%"PRIx64", %d = 0x%"PRIx64 -> > - "%s write(%04x:%02x:%02x.%x:BAR%d+0x%"PRIx64", 0x%"PRIx64", %d)" > "%s write(%04x:%02x:%02x.%x:BAR%d+0x%"PRIx64", 0x%"PRIx64", %d" > This is a temporary fix. > > - This leads to a too large amount of trace points which may not be > eligible as trace points - I don't know?- > - this transformation just is tested compiled on PCI. Tested on platform > qemu configured with --enable-trace-backends=stderr > - in future, format strings and calls may be simplified by using a single > name argument instead of domain, bus, slot, function. I think it's a nice step into the right direction. Alex