From: Peter Rajnoha <prajnoha@redhat.com>
To: lvm-devel@redhat.com
Subject: [PATCH] lvconvert: limit lv types for cache use
Date: Wed, 03 Sep 2014 12:21:15 +0200 [thread overview]
Message-ID: <5406EB9B.5030806@redhat.com> (raw)
In-Reply-To: <5406DC10.9020108@redhat.com>
On 09/03/2014 11:14 AM, Zdenek Kabelac wrote:
> Dne 2.9.2014 v 22:56 David Teigland napsal(a):
>> +static const char *lv_is_name(struct logical_volume *lv)
>> +{
>> + if (lv_is_external_origin(lv))
>> + return "external_origin";
>> +
>
> There is already a reporting function for this with new Petr's patches.
>
>
That's the lv_layout_and_role fn. However, this one produces two lists
of strings, not single concatenated string (for both "layout" and "role").
It was designed for reporting lv_layout and lv_role fields originally.
So this would need to be patched a little bit to produce a single string
that is suitable for issuing messages.
But yes, to keep the consistency here, the same identification should be
used for messages too. I'll add a patch for that.
--
Peter
next prev parent reply other threads:[~2014-09-03 10:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-02 20:56 [PATCH] lvconvert: limit lv types for cache use David Teigland
2014-09-03 9:14 ` Zdenek Kabelac
2014-09-03 10:21 ` Peter Rajnoha [this message]
2014-09-03 15:30 ` David Teigland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5406EB9B.5030806@redhat.com \
--to=prajnoha@redhat.com \
--cc=lvm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.