All of lore.kernel.org
 help / color / mirror / Atom feed
From: Razvan Cojocaru <rcojocaru@bitdefender.com>
To: xen-devel@lists.xenproject.org
Cc: kevin.tian@intel.com, keir@xen.org, ian.campbell@citrix.com,
	stefano.stabellini@eu.citrix.com, jun.nakajima@intel.com,
	eddie.dong@intel.com, ian.jackson@eu.citrix.com, tim@xen.org,
	jbeulich@suse.com, andrew.cooper3@citrix.com
Subject: Re: [PATCH 2/5] xen: Optimize introspection access to guest state
Date: Wed, 03 Sep 2014 14:11:43 +0300	[thread overview]
Message-ID: <5406F76F.2090300@bitdefender.com> (raw)
In-Reply-To: <1409730301-13155-2-git-send-email-rcojocaru@bitdefender.com>

On 09/03/2014 10:44 AM, Razvan Cojocaru wrote:
> Speed optimization for introspection purposes: a handful of registers
> are sent along with each mem_event. This requires enlargement of the
> mem_event_request / mem_event_response stuctures, and additional code
> to fill in relevant values. Since the EPT event processing code needs
> more data than CR3 or MSR event processors, hvm_mem_event_fill_regs()
> fills in less data than p2m_mem_event_fill_regs(), in order to avoid
> overhead. Struct hvm_hw_cpu has been considered instead of the custom
> struct mem_event_regs_st, but its size would cause quick filling up
> of the mem_event ring buffer.
> 
> Signed-off-by: Razvan Cojocaru <rcojocaru@bitdefender.com>
> Acked-by: Jan Beulich <jbeulich@suse.com>
> ---
>  tools/libxc/xc_mem_access.c        |   10 +++++++++-
>  tools/libxc/xc_mem_event.c         |    7 +++++--
>  tools/libxc/xc_private.h           |    2 +-
>  tools/libxc/xenctrl.h              |    2 ++
>  xen/arch/x86/hvm/vmx/vmcs.c        |   25 +++++++++++++++++++++++++
>  xen/arch/x86/hvm/vmx/vmx.c         |   13 +++++++++++++
>  xen/arch/x86/mm/mem_event.c        |   11 +++++++++++
>  xen/include/asm-x86/hvm/domain.h   |    1 +
>  xen/include/asm-x86/hvm/hvm.h      |    2 ++
>  xen/include/asm-x86/hvm/vmx/vmcs.h |    7 +++++++
>  xen/include/public/domctl.h        |    7 ++++---
>  11 files changed, 80 insertions(+), 7 deletions(-)

Sorry, I've managed to switch the description of patches 2 and 3. I'll
send V2 shortly with the correction.


Thanks,
Razvan Cojocaru

  reply	other threads:[~2014-09-03 11:11 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-03  7:44 [PATCH 1/5] xen: Emulate with no writes Razvan Cojocaru
2014-09-03  7:44 ` [PATCH 2/5] xen: Optimize introspection access to guest state Razvan Cojocaru
2014-09-03 11:11   ` Razvan Cojocaru [this message]
2014-09-03  7:44 ` [PATCH 3/5] xen, libxc: Force-enable relevant MSR events Razvan Cojocaru
2014-09-03  7:45 ` [PATCH 4/5] xen, libxc: Request page fault injection via libxc Razvan Cojocaru
2014-09-03  7:45 ` [PATCH 5/5] xen: Handle resumed instruction based on previous mem_event reply Razvan Cojocaru

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5406F76F.2090300@bitdefender.com \
    --to=rcojocaru@bitdefender.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=eddie.dong@intel.com \
    --cc=ian.campbell@citrix.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=jbeulich@suse.com \
    --cc=jun.nakajima@intel.com \
    --cc=keir@xen.org \
    --cc=kevin.tian@intel.com \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=tim@xen.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.