Re: [Qemu-devel] [PATCH v3] block: Introduce "null" driver

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1238 bytes --]

On 09/03/2014 05:10 AM, Kevin Wolf wrote:

>>>> @@ -1150,7 +1150,8 @@
>>>>    'data': [ 'archipelago', 'file', 'host_device', 'host_cdrom', 'host_floppy',
>>>>              'http', 'https', 'ftp', 'ftps', 'tftp', 'vvfat', 'blkdebug',
>>>>              'blkverify', 'bochs', 'cloop', 'cow', 'dmg', 'parallels', 'qcow',
>>>> -            'qcow2', 'qed', 'raw', 'vdi', 'vhdx', 'vmdk', 'vpc', 'quorum' ] }
>>>> +            'qcow2', 'qed', 'raw', 'vdi', 'vhdx', 'vmdk', 'vpc', 'quorum',
>>>> +            'null' ] }
>>>
>>> As mentioned elsewhere, you probably want 'null' AND 'null-co'.  Bummer
>>> that this list is mostly alphabetical, but that 'quorum' and 'null' are
>>> out of order.
>>
>> I'll add null-co to the list. But this list is a bit far from alphabetical:
>>
>> archipelago, ..., vvfat, blkdebug,...
> 
> Actually it's pretty close to alphabetical as the secondary criterion
> (the primary one is that all protocols are listed first, and only then
> the formats).

Then a (separate) patch that lists:

'data': [
   # protocols
   list...,
   # formats
   list...
]

might be nice :)

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 539 bytes --]