From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [PATCH] x86/HVM: restore parentheses lost by 3d4d4f9336 Date: Wed, 3 Sep 2014 13:53:59 +0100 Message-ID: <54070F67.4080703@citrix.com> References: <54072ADB02000078000304CC@mail.emea.novell.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7534945146486116840==" Return-path: Received: from mail6.bemta4.messagelabs.com ([85.158.143.247]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1XPA4Z-00033s-Vr for xen-devel@lists.xenproject.org; Wed, 03 Sep 2014 12:54:07 +0000 In-Reply-To: <54072ADB02000078000304CC@mail.emea.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich , xen-devel Cc: Tamas K Lengyel List-Id: xen-devel@lists.xenproject.org --===============7534945146486116840== Content-Type: multipart/alternative; boundary="------------000807090509060606040500" --------------000807090509060606040500 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit On 03/09/14 13:51, Jan Beulich wrote: > ("x86: consolidate boolean inputs in hvm and p2m into a shared bitmap") > > Coverity-ID: 1234366 > > Signed-off-by: Jan Beulich Ah - I had already posted a patch for this, but as the the change is identical, Reviewed-by: Andrew Cooper > > --- a/xen/arch/x86/hvm/hvm.c > +++ b/xen/arch/x86/hvm/hvm.c > @@ -2796,7 +2796,7 @@ int hvm_hap_nested_page_fault(paddr_t gp > > p2m = p2m_get_hostp2m(v->domain); > mfn = get_gfn_type_access(p2m, gfn, &p2mt, &p2ma, > - P2M_ALLOC | npfec.write_access ? P2M_UNSHARE : 0, > + P2M_ALLOC | (npfec.write_access ? P2M_UNSHARE : 0), > NULL); > > /* Check access permissions first, then handle faults */ > > > > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xen.org > http://lists.xen.org/xen-devel --------------000807090509060606040500 Content-Type: text/html; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit
On 03/09/14 13:51, Jan Beulich wrote:
("x86: consolidate boolean inputs in hvm and p2m into a shared bitmap")

Coverity-ID: 1234366

Signed-off-by: Jan Beulich <jbeulich@suse.com>

Ah - I had already posted a patch for this, but as the the change is identical, Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>


--- a/xen/arch/x86/hvm/hvm.c
+++ b/xen/arch/x86/hvm/hvm.c
@@ -2796,7 +2796,7 @@ int hvm_hap_nested_page_fault(paddr_t gp
 
     p2m = p2m_get_hostp2m(v->domain);
     mfn = get_gfn_type_access(p2m, gfn, &p2mt, &p2ma, 
-                              P2M_ALLOC | npfec.write_access ? P2M_UNSHARE : 0,
+                              P2M_ALLOC | (npfec.write_access ? P2M_UNSHARE : 0),
                               NULL);
 
     /* Check access permissions first, then handle faults */






_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

--------------000807090509060606040500-- --===============7534945146486116840== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============7534945146486116840==--