From mboxrd@z Thu Jan  1 00:00:00 1970
From: Don Slutz <dslutz@verizon.com>
Subject: Re: [PATCH] x86/HVM: restore parentheses lost by
	3d4d4f9336
Date: Wed, 03 Sep 2014 08:56:51 -0400
Message-ID: <54071013.6040308@terremark.com>
References: <54072ADB02000078000304CC@mail.emea.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta4.messagelabs.com ([85.158.143.247])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <dslutz@verizon.com>) id 1XPA7L-0003Qc-Hu
	for xen-devel@lists.xenproject.org; Wed, 03 Sep 2014 12:56:56 +0000
In-Reply-To: <54072ADB02000078000304CC@mail.emea.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>, xen-devel <xen-devel@lists.xenproject.org>
Cc: Tamas K Lengyel <tamas.lengyel@zentific.com>
List-Id: xen-devel@lists.xenproject.org

On 09/03/14 08:51, Jan Beulich wrote:
> ("x86: consolidate boolean inputs in hvm and p2m into a shared bitmap")
>
> Coverity-ID: 1234366
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Looks good.

Reviewed-by:  Don Slutz <dslutz@verizon.com>



> --- a/xen/arch/x86/hvm/hvm.c
> +++ b/xen/arch/x86/hvm/hvm.c
> @@ -2796,7 +2796,7 @@ int hvm_hap_nested_page_fault(paddr_t gp
>   
>       p2m = p2m_get_hostp2m(v->domain);
>       mfn = get_gfn_type_access(p2m, gfn, &p2mt, &p2ma,
> -                              P2M_ALLOC | npfec.write_access ? P2M_UNSHARE : 0,
> +                              P2M_ALLOC | (npfec.write_access ? P2M_UNSHARE : 0),
>                                 NULL);
>   
>       /* Check access permissions first, then handle faults */
>
>
>
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel