From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomeu Vizoso Subject: Re: [PATCH v8 3/7] clk: Move all drivers to use internal API Date: Wed, 03 Sep 2014 14:59:38 +0200 Message-ID: <540710BA.60108@collabora.com> References: <1409585377-26091-1-git-send-email-tomeu.vizoso@collabora.com> <1409585574-26673-1-git-send-email-tomeu.vizoso@collabora.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linuxppc-dev-bounces+glppe-linuxppc-embedded-2=m.gmane.org@lists.ozlabs.org Sender: "Linuxppc-dev" To: Ulf Hansson Cc: Andrew Lunn , alsa-devel@alsa-project.org, Prashant Gaikwad , Tony Lindgren , Tomasz Figa , Liam Girdwood , Thierry Reding , Paul Mackerras , Sylwester Nawrocki , Daniel Walker , linux-arch@vger.kernel.org, Boris Brezillon , linux-samsung-soc , Kukjin Kim , Mike Turquette , =?UTF-8?B?RW1pbGlvIEzDs3Bleg==?= , Takashi Iwai , Michal Simek , Kyungmin Park , Kevin Hilman , linux-omap , "linux-arm-kernel@lists.infradead.org" List-Id: alsa-devel@alsa-project.org T24gMDkvMDIvMjAxNCAwOToxMyBBTSwgVWxmIEhhbnNzb24gd3JvdGU6Cj4gT24gMSBTZXB0ZW1i ZXIgMjAxNCAxNzozMiwgVG9tZXUgVml6b3NvIDx0b21ldS52aXpvc29AY29sbGFib3JhLmNvbT4g d3JvdGU6Cj4+IEluIHByZXBhcmF0aW9uIHRvIGNoYW5nZSB0aGUgcHVibGljIEFQSSB0byByZXR1 cm4gYSBwZXItdXNlciBjbGsgc3RydWN0dXJlLAo+PiByZW1vdmUgYW55IHVzYWdlIG9mIHRoaXMg cHVibGljIEFQSSBmcm9tIHRoZSBjbG9jayBpbXBsZW1lbnRhdGlvbnMuCj4+Cj4+IFRoZSByZWFz b24gZm9yIGhhdmluZyB0aGlzIGluIGEgc2VwYXJhdGUgY29tbWl0IGZyb20gdGhlIG9uZSB0aGF0 IGludHJvZHVjZXMKPj4gdGhlIGltcGxlbWVudGF0aW9uIG9mIHRoZSBuZXcgZnVuY3Rpb25zIGlz IHRvIHNlcGFyYXRlIHRoZSBjaGFuZ2VzIGdlbmVyYXRlZAo+PiB3aXRoIENvY2NpbmVsbGUgZnJv bSB0aGUgcmVzdCwgYW5kIGtlZXAgdGhlIHBhdGNoZXMnIHNpemUgcmVhc29uYWJsZS4KPj4KPj4g U2lnbmVkLW9mZi1ieTogVG9tZXUgVml6b3NvIDx0b21ldS52aXpvc29AY29sbGFib3JhLmNvbT4K Pj4gVGVzdGVkLWJ5OiBCb3JpcyBCcmV6aWxsb24gPGJvcmlzLmJyZXppbGxvbkBmcmVlLWVsZWN0 cm9ucy5jb20+Cj4+IFRlc3RlZC1ieTogSGVpa28gU3R1ZWJuZXIgPGhlaWtvQHNudGVjaC5kZT4K Pj4gQWNrZWQtYnk6IEJvcmlzIEJyZXppbGxvbiA8Ym9yaXMuYnJlemlsbG9uQGZyZWUtZWxlY3Ry b25zLmNvbT4KPgo+IEhpIFRvbWV1LAo+Cj4gSHVoLCB3aGF0IGEgcGF0Y2guIDotKSBHcmVhdCB3 b3JrIHlvdSBhcmUgZG9pbmcgaGVyZSEKClRoYW5rcyEKCj4gQnkganVzdCBsb29raW5nIGF0IHRo ZSB1eDUwMCBjaGFuZ2VzLCBJIHJlYWxpemUgdGhhdCB5b3Ugbm93IGhhdmUKPiByZW1vdmVkIHRo ZSBkZXBlbmRlbmN5IHRvICJzdHJ1Y3QgY2xrIiwgdGh1cyB3ZSBzaG91bGRuJ3QgaW5jbHVkZSB0 aGUKPiBoZWFkZXIgZmlsZSBsaW51eC9jbGsuaCBpbiBhbnkgZmlsZSBsb2NhdGVkIGluIGRyaXZl ci9jbGsvdXg1MDAvKiwKPiByaWdodCE/Cj4KPiBJIHN1cHBvc2UgdGhpcyBjb21tZW50IG1heSBh bHNvIGFwcGxpY2FibGUgZm9yIG90aGVycyB0aGFuIHRoZSB1eDUwMAo+IGNsayBkcml2ZXIsIGJ1 dCBoYXZlbid0IGNoZWNrZWQuCgpZb3UgYXJlIHJpZ2h0LiBJIGhhdmUgZ29uZSBhaGVhZCBhbmQg cmVtb3ZlZCB0aGUgaW5jbHVkZSBmcm9tIGFsbCBmaWxlcyAKdGhhdCBhcmUgZmVkIHRvIHRoZSBj b2NjaW5lbGxlIHNjcmlwdC4gRXZlcnl0aGluZyBidWlsZHMgZmluZSBpbiBhbGwgCmNvbmZpZ3Vy YXRpb25zIEkgaGF2ZSB0ZXN0ZWQsIHNvIEkgd2lsbCBiZSBhZGRpbmcgaXQgdG8gdjkuCgpUaGFu a3MgZm9yIHRoZSBpZGVhLAoKVG9tZXUKCgo+IEtpbmQgcmVnYXJkcwo+IFVmZmUKPgoKX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KTGludXhwcGMtZGV2IG1h aWxpbmcgbGlzdApMaW51eHBwYy1kZXZAbGlzdHMub3psYWJzLm9yZwpodHRwczovL2xpc3RzLm96 bGFicy5vcmcvbGlzdGluZm8vbGludXhwcGMtZGV2 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [93.93.135.160]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 1D7661A002C for ; Wed, 3 Sep 2014 22:59:54 +1000 (EST) Message-ID: <540710BA.60108@collabora.com> Date: Wed, 03 Sep 2014 14:59:38 +0200 From: Tomeu Vizoso MIME-Version: 1.0 To: Ulf Hansson Subject: Re: [PATCH v8 3/7] clk: Move all drivers to use internal API References: <1409585377-26091-1-git-send-email-tomeu.vizoso@collabora.com> <1409585574-26673-1-git-send-email-tomeu.vizoso@collabora.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Cc: Andrew Lunn , alsa-devel@alsa-project.org, Prashant Gaikwad , Tony Lindgren , Tomasz Figa , Liam Girdwood , Thierry Reding , Paul Mackerras , Sylwester Nawrocki , Daniel Walker , linux-arch@vger.kernel.org, Boris Brezillon , linux-samsung-soc , Kukjin Kim , Mike Turquette , =?UTF-8?B?RW1pbGlvIEzDs3Bleg==?= , Takashi Iwai , Michal Simek , Kyungmin Park , Kevin Hilman , linux-omap , "linux-arm-kernel@lists.infradead.org" , patches@opensource.wolfsonmicro.com, Viresh Kumar , David Brown , Anatolij Gustschin , Dinh Nguyen , Sebastian Hesselbarth , Jason Cooper , Arnd Bergmann , Stephen Warren , "linux-arm-msm@vger.kernel.org" , spear-devel@list.st.com, Barry Song , Mark Brown , linux-rpi-kernel@lists.infradead.org, Ben Dooks , "linux-tegra@vger.kernel.org" , Russell King , Jaroslav Kysela , Sascha Hauer , Shawn Guo , Paul Walmsley , Peter De Schrijver , "linux-kernel@vger.kernel.org" , rabin@rab.in, Bryan Huntsman , Santosh Shilimkar , =?UTF-8?B?QmVub8OudCBDb3Vzc29u?= , Maxime Ripard , linux-media@vger.kernel.org, "linuxppc-dev@lists.ozlabs.org" , Mauro Carvalho Chehab List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 09/02/2014 09:13 AM, Ulf Hansson wrote: > On 1 September 2014 17:32, Tomeu Vizoso wrote: >> In preparation to change the public API to return a per-user clk structure, >> remove any usage of this public API from the clock implementations. >> >> The reason for having this in a separate commit from the one that introduces >> the implementation of the new functions is to separate the changes generated >> with Coccinelle from the rest, and keep the patches' size reasonable. >> >> Signed-off-by: Tomeu Vizoso >> Tested-by: Boris Brezillon >> Tested-by: Heiko Stuebner >> Acked-by: Boris Brezillon > > Hi Tomeu, > > Huh, what a patch. :-) Great work you are doing here! Thanks! > By just looking at the ux500 changes, I realize that you now have > removed the dependency to "struct clk", thus we shouldn't include the > header file linux/clk.h in any file located in driver/clk/ux500/*, > right!? > > I suppose this comment may also applicable for others than the ux500 > clk driver, but haven't checked. You are right. I have gone ahead and removed the include from all files that are fed to the coccinelle script. Everything builds fine in all configurations I have tested, so I will be adding it to v9. Thanks for the idea, Tomeu > Kind regards > Uffe >