From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Marchand Subject: Re: [PATCH v4 00/14] ivshmem: update documentation, add client/server tools Date: Wed, 03 Sep 2014 15:01:41 +0200 Message-ID: <54071135.30100@6wind.com> References: <1409671532-12706-1-git-send-email-david.marchand@6wind.com> <5406290C.3010105@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, stefanha@gmail.com, claudio.fontana@huawei.com, qemu-devel@nongnu.org, armbru@redhat.com, arei.gonglei@huawei.com, pbonzini@redhat.com, jani.kokkonen@huawei.com, cam@cs.ualberta.ca To: Eric Blake Return-path: In-Reply-To: <5406290C.3010105@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org Sender: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org List-Id: kvm.vger.kernel.org Hello Eric, On 09/02/2014 10:31 PM, Eric Blake wrote: > On 09/02/2014 09:25 AM, David Marchand wrote: >> Here is a patchset containing an update on ivshmem specs documentation and >> importing ivshmem server and client tools. >> These tools have been written from scratch and are not related to what is >> available in nahanni repository. >> I put them in contrib/ directory as the qemu-doc.texi was already telling the >> server was supposed to be there. >> >> Changes since v3: >> - first patch is untouched >> - just restored the Reviewed-By Claudio in second patch >> - following patches 3-8 take into account Stefan's comments >> - patches 9-12 take into account Gonglei's comments >> - patch 13 adjusts ivshmem-server default values >> - last patch introduces a change in the ivshmem client-server protocol to >> check a protocol version at connect time > > Rather than introducing new files with bugs, followed by patches to > clean it up, why not just introduce the new files correct in the first > place? I think you are better off squashing in a lot of the cleanup > patches into patch 1. Actually, I mentioned this in a previous email but did not get any comment. So, I preferred to send the splitted patches to ease review (from my point of view). Once code looks fine enough, I intend to keep only three patches : - one for the initial import of ivshmem-client / server - one for the documentation update - one last with the protocol change Is it okay this way ? -- David Marchand From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51230) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XPAC9-0006h9-Nt for qemu-devel@nongnu.org; Wed, 03 Sep 2014 09:02:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XPAC1-0004Tb-6g for qemu-devel@nongnu.org; Wed, 03 Sep 2014 09:01:53 -0400 Received: from mail-wg0-f49.google.com ([74.125.82.49]:64320) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XPAC1-0004TK-0s for qemu-devel@nongnu.org; Wed, 03 Sep 2014 09:01:45 -0400 Received: by mail-wg0-f49.google.com with SMTP id y10so8420540wgg.8 for ; Wed, 03 Sep 2014 06:01:43 -0700 (PDT) Message-ID: <54071135.30100@6wind.com> Date: Wed, 03 Sep 2014 15:01:41 +0200 From: David Marchand MIME-Version: 1.0 References: <1409671532-12706-1-git-send-email-david.marchand@6wind.com> <5406290C.3010105@redhat.com> In-Reply-To: <5406290C.3010105@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v4 00/14] ivshmem: update documentation, add client/server tools List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: kvm@vger.kernel.org, stefanha@gmail.com, claudio.fontana@huawei.com, qemu-devel@nongnu.org, armbru@redhat.com, arei.gonglei@huawei.com, pbonzini@redhat.com, jani.kokkonen@huawei.com, cam@cs.ualberta.ca Hello Eric, On 09/02/2014 10:31 PM, Eric Blake wrote: > On 09/02/2014 09:25 AM, David Marchand wrote: >> Here is a patchset containing an update on ivshmem specs documentation and >> importing ivshmem server and client tools. >> These tools have been written from scratch and are not related to what is >> available in nahanni repository. >> I put them in contrib/ directory as the qemu-doc.texi was already telling the >> server was supposed to be there. >> >> Changes since v3: >> - first patch is untouched >> - just restored the Reviewed-By Claudio in second patch >> - following patches 3-8 take into account Stefan's comments >> - patches 9-12 take into account Gonglei's comments >> - patch 13 adjusts ivshmem-server default values >> - last patch introduces a change in the ivshmem client-server protocol to >> check a protocol version at connect time > > Rather than introducing new files with bugs, followed by patches to > clean it up, why not just introduce the new files correct in the first > place? I think you are better off squashing in a lot of the cleanup > patches into patch 1. Actually, I mentioned this in a previous email but did not get any comment. So, I preferred to send the splitted patches to ease review (from my point of view). Once code looks fine enough, I intend to keep only three patches : - one for the initial import of ivshmem-client / server - one for the documentation update - one last with the protocol change Is it okay this way ? -- David Marchand