From mboxrd@z Thu Jan  1 00:00:00 1970
From: Razvan Cojocaru <rcojocaru@bitdefender.com>
Subject: Re: [PATCH RFC V11 2/5] xen: Optimize introspection
 access to guest state
Date: Wed, 03 Sep 2014 16:10:06 +0300
Message-ID: <5407132E.5000405@bitdefender.com>
References: <1409672239-19520-1-git-send-email-rcojocaru@bitdefender.com>	<1409672239-19520-2-git-send-email-rcojocaru@bitdefender.com>
	<1409749606.23789.10.camel@kazak.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta5.messagelabs.com ([195.245.231.135])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <rcojocaru@bitdefender.com>) id 1XPAKK-0004eU-Jo
	for xen-devel@lists.xenproject.org; Wed, 03 Sep 2014 13:10:20 +0000
In-Reply-To: <1409749606.23789.10.camel@kazak.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: kevin.tian@intel.com, eddie.dong@intel.com, stefano.stabellini@eu.citrix.com, jun.nakajima@intel.com, andrew.cooper3@citrix.com, tim@xen.org, JBeulich@suse.com, xen-devel@lists.xenproject.org, ian.jackson@eu.citrix.com
List-Id: xen-devel@lists.xenproject.org

On 09/03/2014 04:06 PM, Ian Campbell wrote:
> On Tue, 2014-09-02 at 18:37 +0300, Razvan Cojocaru wrote:
>>  
>>  void *xc_mem_access_enable(xc_interface *xch, domid_t domain_id, uint32_t *port)
>>  {
>> -    return xc_mem_event_enable(xch, domain_id, HVM_PARAM_ACCESS_RING_PFN, port);
>> +    return xc_mem_event_enable(xch, domain_id, HVM_PARAM_ACCESS_RING_PFN,
>> +                               port, 0);
>> +}
>> +
>> +void *xc_mem_access_enable_introspection(xc_interface *xch, domid_t domain_id,
>> +                                         uint32_t *port)
> 
> I'm not really sure the _introspection suffix is the best description of
> what is actually going on here. It looks more like an "extended context
> in event" type thing or something AFAICT.
> 
> But none the less the code seems correct even if the naming isn't ideal,
> so for the toolstack side:
> 
> Acked-by: Ian Campbell <ian.campbell@citrix.com>

Thanks! I'll make sure to add the Acked-by tag to the next iteration of
the series (in the meantime it's become [PATCH V2]).


Thanks,
Razvan Cojocaru