From: Richard Henderson <rth@twiddle.net>
To: Artyom Tarasenko <atar4qemu@gmail.com>,
Peter Maydell <peter.maydell@linaro.org>
Cc: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>,
qemu-devel <qemu-devel@nongnu.org>,
patches@linaro.org
Subject: Re: [Qemu-devel] [PATCH v2 2/3] target-sparc: address_mask(), asi_address_mask() are TARGET_SPARC64 only
Date: Wed, 03 Sep 2014 08:09:40 -0700 [thread overview]
Message-ID: <54072F34.2030808@twiddle.net> (raw)
In-Reply-To: <CACXAS8AOjWvYYBVysw2-WhnfjQmoadZBVzc3fn2DZkHUkHG98w@mail.gmail.com>
On 09/03/2014 01:49 AM, Artyom Tarasenko wrote:
> On Tue, Sep 2, 2014 at 1:52 PM, Peter Maydell <peter.maydell@linaro.org> wrote:
>> The address_mask() and asi_address_mask() functions are only used in
>> TARGET_SPARC64 configs, so guard with ifdefs to avoid warnings about
>> unused functions in 32-bit builds.
>>
>> Since the main reason these functions were marked 'inline' was to
>> suppress unused-function warnings with gcc, we remove the 'inline'
>> as no longer necessary.
>
> I thought address_mask was inline because it's in the hot path.
> Wouldn't the removal hit performance?
The compiler will probably inline it itself as it sees fit.
r~
next prev parent reply other threads:[~2014-09-03 15:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-02 11:52 [Qemu-devel] [PATCH v2 0/3] target-sparc: fixed unused function warnings Peter Maydell
2014-09-02 11:52 ` [Qemu-devel] [PATCH v2 1/3] target-sparc: Remove unused gen_op_subi_cc and gen_op_addi_cc Peter Maydell
2014-09-02 11:52 ` [Qemu-devel] [PATCH v2 2/3] target-sparc: address_mask(), asi_address_mask() are TARGET_SPARC64 only Peter Maydell
2014-09-03 8:49 ` Artyom Tarasenko
2014-09-03 15:09 ` Richard Henderson [this message]
2014-09-02 11:52 ` [Qemu-devel] [PATCH v2 3/3] target-sparc: is_translating_asi() is " Peter Maydell
2014-09-02 13:17 ` [Qemu-devel] [PATCH v2 0/3] target-sparc: fixed unused function warnings Richard Henderson
2014-09-02 13:35 ` Mark Cave-Ayland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54072F34.2030808@twiddle.net \
--to=rth@twiddle.net \
--cc=atar4qemu@gmail.com \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=patches@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.