From: Maarten Lankhorst <maarten.lankhorst@canonical.com>
To: David Airlie <airlied@linux.ie>
Cc: "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>
Subject: [PATCH 2/3] drm/qxl: fix gaping memory hole
Date: Wed, 03 Sep 2014 17:12:22 +0200 [thread overview]
Message-ID: <54072FD6.10907@canonical.com> (raw)
In-Reply-To: <54072F9B.7090304@canonical.com>
This is how you implement a sieve in a driver. ;-)
Signed-off-by: Maarten Lankhorst <maarten.lankhorst@canonical.com>
---
drivers/gpu/drm/qxl/qxl_release.c | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/qxl/qxl_release.c b/drivers/gpu/drm/qxl/qxl_release.c
index 828d47e90dce..29ab4ec44c40 100644
--- a/drivers/gpu/drm/qxl/qxl_release.c
+++ b/drivers/gpu/drm/qxl/qxl_release.c
@@ -162,12 +162,14 @@ static void
qxl_release_free_list(struct qxl_release *release)
{
while (!list_empty(&release->bos)) {
- struct ttm_validate_buffer *entry;
+ struct qxl_bo_list *entry;
+ struct qxl_bo *bo;
entry = container_of(release->bos.next,
- struct ttm_validate_buffer, head);
-
- list_del(&entry->head);
+ struct qxl_bo_list, tv.head);
+ bo = to_qxl_bo(entry->tv.bo);
+ qxl_bo_unref(&bo);
+ list_del(&entry->tv.head);
kfree(entry);
}
}
--
2.0.4
next prev parent reply other threads:[~2014-09-03 15:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-03 15:11 [PATCH 1/3] drm/qxl: Remove release_lock stupidity Maarten Lankhorst
2014-09-03 15:12 ` Maarten Lankhorst [this message]
2014-09-03 15:13 ` [PATCH 3/3] drm/qxl: Fix crash in eviction from, qxl_release_fence_buffer_objects Maarten Lankhorst
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54072FD6.10907@canonical.com \
--to=maarten.lankhorst@canonical.com \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.