From: Peter A. Bigot <pab@pabigot.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] env_mmc: correct fini partition to match init partition
Date: Wed, 03 Sep 2014 12:30:31 -0500 [thread overview]
Message-ID: <54075037.1030601@pabigot.com> (raw)
In-Reply-To: <5407473E.2000909@wwwdotorg.org>
On 09/03/2014 11:52 AM, Stephen Warren wrote:
> On 09/03/2014 10:32 AM, Peter A. Bigot wrote:
>> The code to set the MMC partition uses an weak function to obtain the
>> correct partition number. Use that instead of the compile-time default
>> when deciding whether it needs to switch back.
>
> Yes, this clearly fixes a bug.
>
> Can you also please add a Fixes: tag that refers to the commit which
> introduced the problem (i.e. which updated mmc_set_env_part() to call
> mmc_get_env_part(), but forgot to update fini_mmc_for_env() to match.
Done.
If this tag is important enough to ask people to add it and resubmit
their patches with no other changes, it should probably be described at
http://www.denx.de/wiki/view/U-Boot/Patches#Review_Process_Git_Tags and
suggested in the section on general patch submission rules, so the poor
contributor might have a chance of being able to avoid the rework.
Peter
next prev parent reply other threads:[~2014-09-03 17:30 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-02 23:31 [U-Boot] [PATCH 0/2] fix issue with mmc partition management Peter A. Bigot
2014-09-02 23:31 ` [U-Boot] [PATCH 1/2] env_mmc: remove condition on call to mmc_switch_part Peter A. Bigot
2014-09-03 15:46 ` Stephen Warren
2014-09-03 16:03 ` Peter A. Bigot
2014-09-03 16:32 ` [U-Boot] [PATCH v2] env_mmc: correct fini partition to match init partition Peter A. Bigot
2014-09-03 16:52 ` Stephen Warren
2014-09-03 17:30 ` Peter A. Bigot [this message]
2014-09-03 17:46 ` Stephen Warren
2014-09-03 17:55 ` Peter A. Bigot
2014-09-03 17:22 ` [U-Boot] [PATCH v3] " Peter A. Bigot
2014-09-09 15:25 ` Igor Grinberg
2014-09-14 13:21 ` Dmitry Lifshitz
2014-10-02 11:09 ` Pantelis Antoniou
2014-09-02 23:31 ` [U-Boot] [PATCH 2/2] mmc: restore capacity when switching to partition 0 Peter A. Bigot
2014-09-03 15:48 ` Stephen Warren
2014-09-03 15:59 ` Peter A. Bigot
2014-09-03 16:05 ` Stephen Warren
2014-09-03 16:36 ` Peter A. Bigot
2014-09-11 17:45 ` Tom Rini
2014-10-02 11:07 ` Pantelis Antoniou
2014-09-11 15:57 ` [U-Boot] [PATCH 0/2] fix issue with mmc partition management Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54075037.1030601@pabigot.com \
--to=pab@pabigot.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.