All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rik van Riel <riel@redhat.com>
To: Andrew Theurer <atheurer@redhat.com>
Cc: linux-kernel@vger.kernel.org, oleg@redhat.com,
	peterz@infradead.org, umgwanakikbuti@gmail.com,
	fweisbec@gmail.com, akpm@linux-foundation.org, srao@redhat.com,
	lwoodman@redhat.com, Peter Zijlstra <peterz@infradead.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Ingo Molnar <mingo@kernel.org>
Subject: Re: [PATCH 0/3] lockless sys_times and posix_cpu_clock_get
Date: Wed, 03 Sep 2014 14:38:26 -0400	[thread overview]
Message-ID: <54076022.80202@redhat.com> (raw)
In-Reply-To: <198309898.21797553.1408483311099.JavaMail.zimbra@redhat.com>

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 08/19/2014 05:21 PM, Andrew Theurer wrote:
> 
>> Thanks to the feedback from Oleg, Peter, Mike, and Frederic, I
>> seem to have a patch series that manages to do times() 
>> locklessly, and apparently correctly.
> 
> 
>> 
>> Oleg points out that the monotonicity alone is not enough of a 
>> guarantee, but that should probably be attacked separately,
>> since that issue is equally present with and without these
>> patches...
>> 
>> The test case below, slightly changed from the one posted by
>> Spencer Candland in 2009, now runs in 11 seconds instead of 5
>> minutes.
>> 
>> Is it worthwhile?  There apparently are some real workloads that
>> call times() a lot, and I believe Sanjay and Andrew have one
>> sitting around.
> 
> Thanks for doing this.  When running a OLTP workload in a KVM VM,
> we saw a 71% increase in performance!  do_sys_times() was a big
> bottleneck for us.

Thanks Andrew, a 71% performance increase seems like it would be
enough to justify merging these patches...


Peter, Ingo, Andrew,

Do any of you have an objection to these patches?

Which tree should I merge them through?

I am happy to resubmit them against any tree, just let
me know where you want the patches to go.

thanks,

Rik
- -- 
All rights reversed
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQEcBAEBAgAGBQJUB2AiAAoJEM553pKExN6DlKsH/RygM0SAcKcqbhk7qbKgQsFI
fe9mzJeDg5X2OVW1LuKKhpdo0wPiJ6arg3s2kWnJ8YuToMlIYjFwh9V+fwk1p7bV
4X8KYEK1DyJux8ZYwOBXlZORL+mE30scwuOF8B0sY+TepiRHeorv0srTIXgJfGyJ
avv95X/hx5JSqjAeRomHPmIX8VzgbHTXPEzWxVj+64qehI63CqyLGXXSlHPvFL4D
uhIRvCC4WxKNldUX20HZFUlQETsJttWoM14SiT1HZbfZNJxDMkD6kjcNl7Uimw9j
gVQeE4qy5OkdY1RSsVN35mg+mGA8kzUoQV0aEkogXwbJYNB+wFQ7OEupA1BKiGw=
=6lUC
-----END PGP SIGNATURE-----

  reply	other threads:[~2014-09-03 18:38 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-15 20:05 [PATCH 0/3] lockless sys_times and posix_cpu_clock_get riel
2014-08-15 20:05 ` [PATCH 1/3] exit: always reap resource stats in __exit_signal riel
2014-09-08  6:39   ` [tip:sched/core] exit: Always reap resource stats in __exit_signal() tip-bot for Rik van Riel
2014-08-15 20:05 ` [PATCH 2/3] time,signal: protect resource use statistics with seqlock riel
2014-08-16 14:11   ` Oleg Nesterov
2014-08-16 15:07     ` Rik van Riel
2014-08-16 17:40     ` [PATCH v2 " Rik van Riel
2014-08-16 17:50       ` Oleg Nesterov
2014-08-18  4:44         ` Mike Galbraith
2014-08-18 14:03           ` Rik van Riel
2014-08-19 14:26             ` Mike Galbraith
2014-09-08  6:39       ` [tip:sched/core] time, signal: Protect " tip-bot for Rik van Riel
2014-08-15 20:05 ` [PATCH 3/3] sched,time: atomically increment stime & utime riel
2014-08-16 14:55   ` Oleg Nesterov
2014-08-16 14:56     ` Oleg Nesterov
2014-09-08  6:40   ` [tip:sched/core] sched, time: Atomically " tip-bot for Rik van Riel
2014-08-19 21:21 ` [PATCH 0/3] lockless sys_times and posix_cpu_clock_get Andrew Theurer
2014-09-03 18:38   ` Rik van Riel [this message]
2014-09-04  7:48     ` Peter Zijlstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54076022.80202@redhat.com \
    --to=riel@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=atheurer@redhat.com \
    --cc=fweisbec@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lwoodman@redhat.com \
    --cc=mingo@kernel.org \
    --cc=oleg@redhat.com \
    --cc=peterz@infradead.org \
    --cc=srao@redhat.com \
    --cc=umgwanakikbuti@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.