From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sudeep Holla Subject: Re: [PATCH v4 01/11] cpumask: factor out show_cpumap into separate helper function Date: Thu, 04 Sep 2014 13:27:13 +0100 Message-ID: <54085AA1.7020600@arm.com> References: <1409763617-17074-1-git-send-email-sudeep.holla@arm.com> <1409763617-17074-2-git-send-email-sudeep.holla@arm.com> <20140904062006.GC3190@worktop.ger.corp.intel.com> <54082ADD.6040004@arm.com> <20140904092135.GA346@worktop.programming.kicks-ass.net> <54084246.7010705@arm.com> <20140904112551.GC346@worktop.programming.kicks-ass.net> Mime-Version: 1.0 Content-Type: text/plain; charset=WINDOWS-1252; format=flowed Content-Transfer-Encoding: 8BIT Return-path: Received: from service87.mimecast.com ([91.220.42.44]:58530 "EHLO service87.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752306AbaIDM1P convert rfc822-to-8bit (ORCPT ); Thu, 4 Sep 2014 08:27:15 -0400 In-Reply-To: <20140904112551.GC346@worktop.programming.kicks-ass.net> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Peter Zijlstra Cc: Sudeep Holla , LKML , Heiko Carstens , Lorenzo Pieralisi , Greg Kroah-Hartman , "Rafael J. Wysocki" , Bjorn Helgaas , "x86@kernel.org" , "linux-acpi@vger.kernel.org" , "linux-pci@vger.kernel.org" On 04/09/14 12:25, Peter Zijlstra wrote: > On Thu, Sep 04, 2014 at 11:43:18AM +0100, Sudeep Holla wrote: >>> You could make it bitmap_copy_to_buf() I suppose, and then have a >>> cpumask inline wrapper, to be fully consistent with the rest of the >>> implementations. >>> >> >> I liked the second approach, how about patch below ? >> If will munge it into original patch. > > Looks good, one more nit if you will permit :-) > Ofcourse :) >> +int bitmap_copy_to_pagebuf(bool list, const unsigned long *maskp, char *buf) > > Maybe s/copy/print/ or something? Its not really a 'copy' as such since > it very much transforms the bitmap. > Makes sense, will update accordingly. Regards, Sudeep