From: Mugunthan V N <mugunthanvnm@ti.com>
To: Daniel Mack <daniel@zonque.org>, <davem@davemloft.net>
Cc: <julia.lawall@lip6.fr>, <netdev@vger.kernel.org>,
<george.cherian@ti.com>, Daniel Mack <zonque@gmail.com>
Subject: Re: [PATCH] net: ethernet: cpsw: improve interrupt lookup logic in cpsw_probe()
Date: Thu, 4 Sep 2014 19:36:18 +0530 [thread overview]
Message-ID: <540871DA.7090608@ti.com> (raw)
In-Reply-To: <1409814023-10189-1-git-send-email-daniel@zonque.org>
On Thursday 04 September 2014 12:30 PM, Daniel Mack wrote:
> From: Daniel Mack <zonque@gmail.com>
>
> Simplify the interrupt resource lookup code in cpsw_probe() by the
> following:
>
> * Only look at the first member of the resource. As the driver only
> works for DT-enabled platforms anyway, a resource of type
> IORESOURCE_IRQ will only contain one single entry
> (res->start == res->end), so there is no need for the iteration.
>
> * Add a bounds check to avoid overflows if we are passed more than
> ARRAY_SIZE(priv->irqs_table) resources.
>
> * Assign 'ret' with the return value of devm_request_irq() so that
> cpsw_probe() returns the appropriate error code.
>
> * If devm_request_irq() fails, report the error code in the log
> message.
>
> Signed-off-by: Daniel Mack <zonque@gmail.com>
Acked-by: Mugunthan V N <mugunthanvnm@gmail.com>
Regards
Mugunthan V N
next prev parent reply other threads:[~2014-09-04 14:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-04 7:00 [PATCH] net: ethernet: cpsw: improve interrupt lookup logic in cpsw_probe() Daniel Mack
2014-09-04 14:06 ` Mugunthan V N [this message]
2014-09-06 0:17 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=540871DA.7090608@ti.com \
--to=mugunthanvnm@ti.com \
--cc=daniel@zonque.org \
--cc=davem@davemloft.net \
--cc=george.cherian@ti.com \
--cc=julia.lawall@lip6.fr \
--cc=netdev@vger.kernel.org \
--cc=zonque@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.