From: dinguyen@opensource.altera.com (Dinh Nguyen)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv10 1/2] edac: altera: Add Altera SDRAM EDAC support.
Date: Thu, 4 Sep 2014 13:56:22 -0500 [thread overview]
Message-ID: <5408B5D6.6020101@opensource.altera.com> (raw)
In-Reply-To: <20140829160204.GA8835@nazgul.tnic>
On 08/29/2014 11:02 AM, Borislav Petkov wrote:
> On Mon, Aug 11, 2014 at 10:18:12AM -0500, tthayer at opensource.altera.com wrote:
>> From: Thor Thayer <tthayer@opensource.altera.com>
>>
>> This patch adds support for the CycloneV and ArriaV SDRAM controllers.
>> Correction and reporting of SBEs, Panic on DBEs.
>>
>> Signed-off-by: Thor Thayer <tthayer@opensource.altera.com>
>> ---
>> v2: Use the SDRAM controller registers to calculate memory size
>> instead of the Device Tree. Update To & Cc list. Add maintainer
>> information.
>>
>> v3: EDAC driver cleanup based on comments from Mailing list.
>>
>> v4: Panic on DBE. Add macro around inject-error reads to prevent
>> them from being optimized out. Remove of_match_ptr since this
>> will always use Device Tree.
>>
>> v5: Addition of printk to trigger function to ensure read vars
>> are not optimized out.
>>
>> v6: Changes to split out shared SDRAM controller reg (offset 0x00)
>> as a syscon device and allocate ECC specific SDRAM registers
>> to EDAC.
>>
>> v7: No changes. Bump for consistency.
>>
>> v8: Alphabetize headers.
>>
>> v9: Changes to support a MFD SDRAM controller with nested EDAC.
>>
>> v10: Revert to version 5 (syscon) and fix errors found in v5.
>
> EDAC bits look ok to me,
>
> Acked-by: Borislav Petkov <bp@suse.de>
>
> Dinh, please convert that version information above to a nice commit
> message and add it when applying as it is very useful for future
> reference.
>
Thank Boris. I had to fix up the patch a bit by making EDAC_ALTERA_MC a
tristate instead of bool to prevent a build error with allmodconfig.
Dinh
> Thanks.
>
WARNING: multiple messages have this Message-ID (diff)
From: Dinh Nguyen <dinguyen@opensource.altera.com>
To: Borislav Petkov <bp@alien8.de>, tthayer@opensource.altera.com
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
linux@arm.linux.org.uk, sameo@linux.intel.com,
pawel.moll@arm.com, ijc+devicetree@hellion.org.uk,
atull@opensource.altera.com, dougthompson@xmission.com,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
tthayer.linux@gmail.com, rob@landley.net, galak@codeaurora.org,
grant.likely@linaro.org, lee.jones@linaro.org,
delicious.quinoa@gmail.com, linux-arm-kernel@lists.infradead.org,
linux-edac@vger.kernel.org
Subject: Re: [PATCHv10 1/2] edac: altera: Add Altera SDRAM EDAC support.
Date: Thu, 4 Sep 2014 13:56:22 -0500 [thread overview]
Message-ID: <5408B5D6.6020101@opensource.altera.com> (raw)
In-Reply-To: <20140829160204.GA8835@nazgul.tnic>
On 08/29/2014 11:02 AM, Borislav Petkov wrote:
> On Mon, Aug 11, 2014 at 10:18:12AM -0500, tthayer@opensource.altera.com wrote:
>> From: Thor Thayer <tthayer@opensource.altera.com>
>>
>> This patch adds support for the CycloneV and ArriaV SDRAM controllers.
>> Correction and reporting of SBEs, Panic on DBEs.
>>
>> Signed-off-by: Thor Thayer <tthayer@opensource.altera.com>
>> ---
>> v2: Use the SDRAM controller registers to calculate memory size
>> instead of the Device Tree. Update To & Cc list. Add maintainer
>> information.
>>
>> v3: EDAC driver cleanup based on comments from Mailing list.
>>
>> v4: Panic on DBE. Add macro around inject-error reads to prevent
>> them from being optimized out. Remove of_match_ptr since this
>> will always use Device Tree.
>>
>> v5: Addition of printk to trigger function to ensure read vars
>> are not optimized out.
>>
>> v6: Changes to split out shared SDRAM controller reg (offset 0x00)
>> as a syscon device and allocate ECC specific SDRAM registers
>> to EDAC.
>>
>> v7: No changes. Bump for consistency.
>>
>> v8: Alphabetize headers.
>>
>> v9: Changes to support a MFD SDRAM controller with nested EDAC.
>>
>> v10: Revert to version 5 (syscon) and fix errors found in v5.
>
> EDAC bits look ok to me,
>
> Acked-by: Borislav Petkov <bp@suse.de>
>
> Dinh, please convert that version information above to a nice commit
> message and add it when applying as it is very useful for future
> reference.
>
Thank Boris. I had to fix up the patch a bit by making EDAC_ALTERA_MC a
tristate instead of bool to prevent a build error with allmodconfig.
Dinh
> Thanks.
>
WARNING: multiple messages have this Message-ID (diff)
From: Dinh Nguyen <dinguyen@opensource.altera.com>
To: Borislav Petkov <bp@alien8.de>, <tthayer@opensource.altera.com>
Cc: <robherring2@gmail.com>, <pawel.moll@arm.com>,
<mark.rutland@arm.com>, <ijc+devicetree@hellion.org.uk>,
<galak@codeaurora.org>, <rob@landley.net>,
<linux@arm.linux.org.uk>, <atull@opensource.altera.com>,
<delicious.quinoa@gmail.com>, <dougthompson@xmission.com>,
<grant.likely@linaro.org>, <sameo@linux.intel.com>,
<lee.jones@linaro.org>, <devicetree@vger.kernel.org>,
<linux-doc@vger.kernel.org>, <linux-edac@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>, <tthayer.linux@gmail.com>
Subject: Re: [PATCHv10 1/2] edac: altera: Add Altera SDRAM EDAC support.
Date: Thu, 4 Sep 2014 13:56:22 -0500 [thread overview]
Message-ID: <5408B5D6.6020101@opensource.altera.com> (raw)
In-Reply-To: <20140829160204.GA8835@nazgul.tnic>
On 08/29/2014 11:02 AM, Borislav Petkov wrote:
> On Mon, Aug 11, 2014 at 10:18:12AM -0500, tthayer@opensource.altera.com wrote:
>> From: Thor Thayer <tthayer@opensource.altera.com>
>>
>> This patch adds support for the CycloneV and ArriaV SDRAM controllers.
>> Correction and reporting of SBEs, Panic on DBEs.
>>
>> Signed-off-by: Thor Thayer <tthayer@opensource.altera.com>
>> ---
>> v2: Use the SDRAM controller registers to calculate memory size
>> instead of the Device Tree. Update To & Cc list. Add maintainer
>> information.
>>
>> v3: EDAC driver cleanup based on comments from Mailing list.
>>
>> v4: Panic on DBE. Add macro around inject-error reads to prevent
>> them from being optimized out. Remove of_match_ptr since this
>> will always use Device Tree.
>>
>> v5: Addition of printk to trigger function to ensure read vars
>> are not optimized out.
>>
>> v6: Changes to split out shared SDRAM controller reg (offset 0x00)
>> as a syscon device and allocate ECC specific SDRAM registers
>> to EDAC.
>>
>> v7: No changes. Bump for consistency.
>>
>> v8: Alphabetize headers.
>>
>> v9: Changes to support a MFD SDRAM controller with nested EDAC.
>>
>> v10: Revert to version 5 (syscon) and fix errors found in v5.
>
> EDAC bits look ok to me,
>
> Acked-by: Borislav Petkov <bp@suse.de>
>
> Dinh, please convert that version information above to a nice commit
> message and add it when applying as it is very useful for future
> reference.
>
Thank Boris. I had to fix up the patch a bit by making EDAC_ALTERA_MC a
tristate instead of bool to prevent a build error with allmodconfig.
Dinh
> Thanks.
>
next prev parent reply other threads:[~2014-09-04 18:56 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-11 15:18 [PATCHv10 0/2] Addition of Altera EDAC support tthayer at opensource.altera.com
2014-08-11 15:18 ` tthayer
2014-08-11 15:18 ` tthayer
2014-08-11 15:18 ` [PATCHv10 1/2] edac: altera: Add Altera SDRAM " tthayer at opensource.altera.com
2014-08-11 15:18 ` tthayer
2014-08-11 15:18 ` tthayer
2014-08-14 18:49 ` Pavel Machek
2014-08-14 18:49 ` Pavel Machek
2014-08-26 18:38 ` Thor Thayer
2014-08-26 18:38 ` Thor Thayer
2014-08-26 18:38 ` Thor Thayer
2014-08-29 16:02 ` Borislav Petkov
2014-08-29 16:02 ` Borislav Petkov
2014-09-04 18:56 ` Dinh Nguyen [this message]
2014-09-04 18:56 ` Dinh Nguyen
2014-09-04 18:56 ` Dinh Nguyen
2014-08-11 15:18 ` [PATCHv10 2/2] arm: dts: Add Altera SDRAM EDAC bindings & devicetree entries tthayer at opensource.altera.com
2014-08-11 15:18 ` tthayer
2014-08-11 15:18 ` tthayer
2014-08-14 18:49 ` Pavel Machek
2014-08-14 18:49 ` Pavel Machek
2014-08-26 18:39 ` Thor Thayer
2014-08-26 18:39 ` Thor Thayer
2014-08-26 18:39 ` Thor Thayer
2014-08-26 20:28 ` Dinh Nguyen
2014-08-26 20:28 ` Dinh Nguyen
2014-08-26 20:28 ` Dinh Nguyen
2014-08-26 21:25 ` Dinh Nguyen
2014-08-26 21:25 ` Dinh Nguyen
2014-08-27 6:36 ` Borislav Petkov
2014-08-27 6:36 ` Borislav Petkov
2014-08-27 13:06 ` Dinh Nguyen
2014-08-27 13:06 ` Dinh Nguyen
2014-08-27 13:06 ` Dinh Nguyen
2014-08-15 6:42 ` Steffen Trumtrar
2014-08-15 6:42 ` Steffen Trumtrar
2014-08-15 16:07 ` atull
2014-08-15 16:07 ` atull
2014-08-15 16:07 ` atull
2014-08-15 16:41 ` Steffen Trumtrar
2014-08-15 16:41 ` Steffen Trumtrar
2014-08-15 16:47 ` Thor Thayer
2014-08-15 16:47 ` Thor Thayer
2014-08-15 16:47 ` Thor Thayer
2014-08-15 16:54 ` Steffen Trumtrar
2014-08-15 16:54 ` Steffen Trumtrar
2014-09-03 2:30 ` Dinh Nguyen
2014-09-03 2:30 ` Dinh Nguyen
2014-09-03 2:30 ` Dinh Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5408B5D6.6020101@opensource.altera.com \
--to=dinguyen@opensource.altera.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.