From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47435)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <tommusta@gmail.com>) id 1XPd6u-0002LW-0I
	for qemu-devel@nongnu.org; Thu, 04 Sep 2014 15:54:28 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <tommusta@gmail.com>) id 1XPd6p-0000LK-AU
	for qemu-devel@nongnu.org; Thu, 04 Sep 2014 15:54:23 -0400
Message-ID: <5408C355.90401@gmail.com>
Date: Thu, 04 Sep 2014 14:53:57 -0500
From: Tom Musta <tommusta@gmail.com>
MIME-Version: 1.0
References: <1409851240-48126-1-git-send-email-agraf@suse.de>	<CAFEAcA8CXGz4tJOtn8qnhd3tz54jiGeSn3AnQ6zpySWCcDAz2g@mail.gmail.com>
	<859F3497-872B-4EEC-BC9E-93E391A97F70@suse.de>
In-Reply-To: <859F3497-872B-4EEC-BC9E-93E391A97F70@suse.de>
Content-Type: text/plain; charset=Shift_JIS
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [Qemu-ppc] [PULL 00/52] ppc patch queue 2014-09-04
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexander Graf <agraf@suse.de>, Peter Maydell <peter.maydell@linaro.org>
Cc: "qemu-ppc@nongnu.org" <qemu-ppc@nongnu.org>, QEMU Developers <qemu-devel@nongnu.org>

On 9/4/2014 2:13 PM, Alexander Graf wrote:
> 
> 
>> Am 04.09.2014 um 20:38 schrieb Peter Maydell <peter.maydell@linaro.org>:
>>
>>> On 4 September 2014 18:19, Alexander Graf <agraf@suse.de> wrote:
>>> Hi Peter,
>>>
>>> This is my current patch queue for ppc.  Please pull.
>>
>> Hi. I'm afraid this doesn't build (x86, 64bit, gcc
>> 4.8.2, non-debug build):
>>
>>  CC    ppc64abi32-linux-user/linux-user/signal.o
>> /home/petmay01/linaro/qemu-for-merges/linux-user/signal.c: In function
>> esetup_framef:
>> /home/petmay01/linaro/qemu-for-merges/linux-user/signal.c:4698:5:
>> error: right shift count >= width of type [-Werror]
>>     __put_user(set->sig[0] >> 32, &sc->_unused[3]);
>>     ^
>> cc1: all warnings being treated as errors
> 
> Ouch. I guess we're missing ppc64abi32 in travis then - it never complained here ;).
> 
> Will fix in a few hours and resend.
> 
> 
> Alex
> 
>>
>> thanks
>> -- PMM
> 

I am thinking that the way to fix this is by amending patch 5/52 () with this change

diff --git a/linux-user/signal.c b/linux-user/signal.c
index a227213..edecd76 100644
--- a/linux-user/signal.c
+++ b/linux-user/signal.c
@@ -4682,7 +4682,7 @@ static void setup_frame(int sig, struct target_sigaction *ka,

     __put_user(ka->_sa_handler, &sc->handler);
     __put_user(set->sig[0], &sc->oldmask);
-#if defined(TARGET_PPC64)
+#if TARGET_ABI_BITS == 64
     __put_user(set->sig[0] >> 32, &sc->_unused[3]);
 #else
     __put_user(set->sig[1], &sc->_unused[3]);