From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail1.windriver.com (mail1.windriver.com [147.11.146.13]) by mail.openembedded.org (Postfix) with ESMTP id 2C487713E3 for ; Thu, 4 Sep 2014 21:10:38 +0000 (UTC) Received: from ALA-HCA.corp.ad.wrs.com (ala-hca.corp.ad.wrs.com [147.11.189.40]) by mail1.windriver.com (8.14.9/8.14.5) with ESMTP id s84LAcvw025791 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=FAIL) for ; Thu, 4 Sep 2014 14:10:39 -0700 (PDT) Received: from [147.11.116.190] (147.11.116.190) by ALA-HCA.corp.ad.wrs.com (147.11.189.50) with Microsoft SMTP Server id 14.3.174.1; Thu, 4 Sep 2014 14:10:38 -0700 Message-ID: <5408D54D.8090007@windriver.com> Date: Thu, 4 Sep 2014 17:10:37 -0400 From: Randy MacLeod User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.0 MIME-Version: 1.0 To: , Robert Yang References: <76dbc052fe60d5e4e5ba929e8e274cdf5c7572e2.1409584344.git.liezhi.yang@windriver.com> In-Reply-To: <76dbc052fe60d5e4e5ba929e8e274cdf5c7572e2.1409584344.git.liezhi.yang@windriver.com> X-Originating-IP: [147.11.116.190] Subject: Re: [PATCH 11/13] sdparm: add bash to RDEPENDS_sdparm X-BeenThere: openembedded-devel@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list Reply-To: openembedded-devel@lists.openembedded.org List-Id: Using the OpenEmbedded metadata to build Distributions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Sep 2014 21:10:47 -0000 Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit On 14-09-01 11:18 AM, Robert Yang wrote: > Bash scripts: > packages-split/sdparm/usr/bin/sas_disk_blink:#!/bin/bash > packages-split/sdparm/usr/bin/scsi_ch_swp:#!/bin/bash > > Signed-off-by: Robert Yang > --- > meta-oe/recipes-support/sdparm/sdparm_1.08.bb | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/meta-oe/recipes-support/sdparm/sdparm_1.08.bb b/meta-oe/recipes-support/sdparm/sdparm_1.08.bb > index 713e451..be46b96 100644 > --- a/meta-oe/recipes-support/sdparm/sdparm_1.08.bb > +++ b/meta-oe/recipes-support/sdparm/sdparm_1.08.bb > @@ -15,3 +15,5 @@ SRC_URI[md5sum] = "be5786f37499018ef44f409597c92d42" > SRC_URI[sha256sum] = "376b78a414b1a9c47f3f13dbeb963e7a3ec7be126f83927d6856b5f7ac425e57" > > inherit autotools > + > +RDEPENDS_${PN} += "bash" > We should move these scripts to a sdparm-scripts sub-pkg. sdparm is a ~150K executable so making it pull in bash at >1000K isn't good for embedded systems. Neither script appears to be essential: sas_disk_blink - blink the LED on a SAS disk scsi_ch_swp: "Usage: scsi_ch_swp [-h] [-s 0|1] [-v] [-w] " ... "Access the Software Write Protect (SWP) bit in the SCSI control" "mode page and if changed adjust the Linux block device (e.g." "/dev/sdc) settings accordingly. If supported, when the SWP bit" "is set (1) the device is read-only; when clear (0) the device" "is read-write (i.e. its contents can be read and changed)." "When no options given it reads SWP and gets blockdev's RO flag." Comments or concerns? -- # Randy MacLeod. SMTS, Linux, Wind River Direct: 613.963.1350