From: Antti Palosaari <crope@iki.fi>
To: linux-media@vger.kernel.org
Subject: Re: [PATCH 3/3] af9035: remove I2C client differently
Date: Fri, 05 Sep 2014 02:02:34 +0300 [thread overview]
Message-ID: <5408EF8A.5040402@iki.fi> (raw)
In-Reply-To: <20140904225038.GA27825@minime.bse>
On 09/05/2014 01:50 AM, Daniel Glöckner wrote:
> On Fri, Sep 05, 2014 at 12:43:43AM +0300, Antti Palosaari wrote:
>> + switch (state->af9033_config[adap->id].tuner) {
>> + case AF9033_TUNER_IT9135_38:
>> + case AF9033_TUNER_IT9135_51:
>> + case AF9033_TUNER_IT9135_52:
>> + case AF9033_TUNER_IT9135_60:
>> + case AF9033_TUNER_IT9135_61:
>> + case AF9033_TUNER_IT9135_62:
>> + demod2 = 2;
>> + default:
>> + demod2 = 1;
>> + }
>
> Missing break?
>
YES! will fix...
It does not have functionality error in that case, but sure it is wrong
and may jump up later when some changes are done.
regards
Antti
--
http://palosaari.fi/
next prev parent reply other threads:[~2014-09-04 23:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-04 21:43 [PATCH 1/3] dvb-usb-v2: add frontend_detach callback Antti Palosaari
2014-09-04 21:43 ` [PATCH 2/3] dvb-usb-v2: add tuner_detach callback Antti Palosaari
2014-09-04 21:43 ` [PATCH 3/3] af9035: remove I2C client differently Antti Palosaari
2014-09-04 22:50 ` Daniel Glöckner
2014-09-04 23:02 ` Antti Palosaari [this message]
2014-09-05 7:51 ` Antti Palosaari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5408EF8A.5040402@iki.fi \
--to=crope@iki.fi \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.