From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55733) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XPnfk-0007aX-Tk for qemu-devel@nongnu.org; Fri, 05 Sep 2014 03:11:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XPnfb-0008Tx-TD for qemu-devel@nongnu.org; Fri, 05 Sep 2014 03:11:04 -0400 Message-ID: <540961FF.8070602@suse.de> Date: Fri, 05 Sep 2014 09:10:55 +0200 From: Alexander Graf MIME-Version: 1.0 References: <1409246113-6519-1-git-send-email-pbonzini@redhat.com> <1409246113-6519-4-git-send-email-pbonzini@redhat.com> <54075C1A.7060605@gmail.com> In-Reply-To: <54075C1A.7060605@gmail.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [Qemu-ppc] [PATCH 03/17] ppc: fix monitor access to CR List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Tom Musta , Paolo Bonzini , qemu-devel@nongnu.org Cc: dgibson@redhat.com, qemu-ppc@nongnu.org On 03.09.14 20:21, Tom Musta wrote: > On 8/28/2014 12:14 PM, Paolo Bonzini wrote: >> This was off-by-one. >> >> Signed-off-by: Paolo Bonzini >> --- >> monitor.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/monitor.c b/monitor.c >> index 34cee74..ec73dd4 100644 >> --- a/monitor.c >> +++ b/monitor.c >> @@ -2968,7 +2968,7 @@ static target_long monitor_get_ccr (const struct MonitorDef *md, int val) >> >> u = 0; >> for (i = 0; i < 8; i++) >> - u |= env->crf[i] << (32 - (4 * i)); >> + u |= env->crf[i] << (32 - (4 * (i + 1))); >> >> return u; >> } >> > > Reviewed-by: Tom Musta > Thanks, applied to ppc-next. Alex