From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34321) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XPoA9-0000L4-2d for qemu-devel@nongnu.org; Fri, 05 Sep 2014 03:42:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XPoA1-00013A-IL for qemu-devel@nongnu.org; Fri, 05 Sep 2014 03:42:29 -0400 Message-ID: <5409695C.3020401@suse.de> Date: Fri, 05 Sep 2014 09:42:20 +0200 From: Alexander Graf MIME-Version: 1.0 References: <20140904111153.20476.58429.stgit@aravindap> <20140904111328.20476.51234.stgit@aravindap> In-Reply-To: <20140904111328.20476.51234.stgit@aravindap> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [Qemu-ppc] [PATCH v2 1/4] target-ppc: Extend rtas-blob List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Aravinda Prasad , aik@au1.ibm.com, qemu-ppc@nongnu.org, qemu-devel@nongnu.org Cc: benh@au1.ibm.com, paulus@samba.org On 04.09.14 13:13, Aravinda Prasad wrote: > Extend rtas-blob to accommodate error log. Error log > structure is saved in rtas space upon a machine check > exception. > > Signed-off-by: Aravinda Prasad > --- > hw/ppc/spapr.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c > index 4b20e36..4a7c0ae 100644 > --- a/hw/ppc/spapr.c > +++ b/hw/ppc/spapr.c > @@ -1409,6 +1409,10 @@ static void ppc_spapr_init(MachineState *machine) > > filename = qemu_find_file(QEMU_FILE_TYPE_BIOS, "spapr-rtas.bin"); > spapr->rtas_size = get_image_size(filename); > + > + /* Resize blob to accommodate error log at a page aligned address */ > + spapr->rtas_size = TARGET_PAGE_ALIGN(spapr->rtas_size) + TARGET_PAGE_SIZE; I think it's clearer if you do #define RTAS_ERROR_LOG_SIZE 4096 and add this to the aligned size instead. Alex