All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rick Jones <rick.jones2@hp.com>
To: netdev@vger.kernel.org, davem@davemloft.net
Subject: Compilation error on freshly pulled net-next?
Date: Fri, 05 Sep 2014 14:47:43 -0700	[thread overview]
Message-ID: <540A2F7F.8060809@hp.com> (raw)

I was going to do some additional "floor sweeping" and put 
dev_consume_skb_any() into another driver or two, so I did a fresh pull 
of net-next and a make and got:

   CC      net/core/rtnetlink.o
net/core/rtnetlink.c: In function ‘if_nlmsg_size’:
net/core/rtnetlink.c:868:84: error: expected ‘;’ before ‘J’
net/core/rtnetlink.c: At top level:
net/core/rtnetlink.c:420:15: warning: ‘rtnl_link_get_size’ defined but 
not used [-Wunused-function]
net/core/rtnetlink.c:497:15: warning: ‘rtnl_link_get_af_size’ defined 
but not used [-Wunused-function]


Looks like someone slipped a J in there and confused things:

                + rtnl_port_size(dev, ext_filter_mask) /* IFLA_VF_PORTS 
+ IFLA_PORT_SELF */J            + rtnl_link_get_size(dev) /* 
IFLA_LINKINFO */
                + rtnl_link_get_af_size(dev) /* IFLA_AF_SPEC */

(hopefully my mail client won't have mangled things too badly)

What is odd though is a git diff after I've replaced that 'J' with a 
return isn't giving me any output.

rick jones

             reply	other threads:[~2014-09-05 21:47 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-05 21:47 Rick Jones [this message]
2014-09-05 22:09 ` Compilation error on freshly pulled net-next? David Miller
2014-09-05 22:19   ` Rick Jones
2014-09-05 22:21   ` Rustad, Mark D

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=540A2F7F.8060809@hp.com \
    --to=rick.jones2@hp.com \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.