From: Akihiro TSUKADA <tskd08@gmail.com>
To: Mauro Carvalho Chehab <m.chehab@samsung.com>,
Antti Palosaari <crope@iki.fi>
Cc: linux-media@vger.kernel.org
Subject: Re: [PATCH v2 1/5] dvb-core: add a new tuner ops to dvb_frontend for APIv5
Date: Sat, 06 Sep 2014 13:08:59 +0900 [thread overview]
Message-ID: <540A88DB.5020306@gmail.com> (raw)
In-Reply-To: <20140906001726.4929ba2f.m.chehab@samsung.com>
Moikka!,
thanks for the comments and advices.
I had been updating my code and during that, I also found that
updating property cache in tuner_ops.get_signal_strength() was
simple and (seemed to me) better than using a kthread,
so the current implementation (under testing) is just like
what Mauro proposed, but,
> In time: not implementing its own thread has one drawback: the driver needs
> to check if the minimal time needed to get a new stats were already archived.
since I don't know the minimal time and
whether there's a limit in the first place,
I'd like to let users take the responsibility.
>> ... I simply don't understand why you want hook that RF strength call
>> via demod? The frontend cache is shared between demod and tuner. We use
>> it for tuner drivr as well demod driver. Let the tuner driver make RSSI
>> calculation independently without any unneeded relation to demod driver.
I think the main reason for the hook is because the dvb-core calls
ops.get_frontend() everytime before reading of any property cache,
so it is already a nice place to trigger property updates,
and reading any property involves demod (FE as a whole) anyway.
regards,
akihiro
next prev parent reply other threads:[~2014-09-06 6:09 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-27 15:29 [PATCH v2 0/5] dvb: Add support for PT3 ISDB-S/T card tskd08
2014-08-27 15:29 ` [PATCH v2 1/5] dvb-core: add a new tuner ops to dvb_frontend for APIv5 tskd08
2014-08-27 18:09 ` Antti Palosaari
2014-08-28 9:07 ` Akihiro TSUKADA
2014-08-29 1:05 ` Antti Palosaari
2014-08-29 10:45 ` Akihiro TSUKADA
2014-09-06 2:09 ` Antti Palosaari
2014-09-06 2:51 ` Mauro Carvalho Chehab
2014-09-06 2:54 ` Mauro Carvalho Chehab
2014-09-06 3:10 ` Antti Palosaari
2014-09-06 3:17 ` Mauro Carvalho Chehab
2014-09-06 3:34 ` Antti Palosaari
2014-09-06 12:35 ` Mauro Carvalho Chehab
2014-09-06 4:08 ` Akihiro TSUKADA [this message]
2014-09-06 10:36 ` Antti Palosaari
2014-09-06 12:49 ` Mauro Carvalho Chehab
2014-09-06 16:24 ` Malcolm Priestley
2014-09-06 16:31 ` Malcolm Priestley
2014-09-06 21:37 ` Malcolm Priestley
2014-09-06 22:37 ` Mauro Carvalho Chehab
2014-09-06 23:38 ` Antti Palosaari
2014-09-07 9:35 ` Malcolm Priestley
2014-08-27 15:29 ` [PATCH v2 2/5] mxl301rf: add driver for MaxLinear MxL301RF OFDM tuner tskd08
2014-08-27 15:29 ` [PATCH v2 3/5] qm1d1c0042: add driver for Sharp QM1D1C0042 ISDB-S tuner tskd08
2014-08-27 15:29 ` [PATCH v2 4/5] tc90522: add driver for Toshiba TC90522 quad demodulator tskd08
2014-08-31 10:29 ` Matthias Schwarzott
2014-08-31 13:32 ` Akihiro TSUKADA
2014-08-31 19:48 ` Antti Palosaari
2014-09-01 9:54 ` Akihiro TSUKADA
2014-09-06 2:02 ` Antti Palosaari
2014-09-06 2:27 ` Mauro Carvalho Chehab
2014-09-06 3:00 ` DVB clock source (Re: [PATCH v2 4/5] tc90522: add driver for Toshiba TC90522 quad demodulator) Antti Palosaari
2014-09-06 3:11 ` Mauro Carvalho Chehab
2014-09-06 3:20 ` Antti Palosaari
2014-09-06 6:09 ` [PATCH v2 4/5] tc90522: add driver for Toshiba TC90522 quad demodulator Akihiro TSUKADA
2014-09-06 6:51 ` Antti Palosaari
2014-09-06 19:35 ` Akihiro TSUKADA
2014-09-07 1:05 ` Antti Palosaari
2014-09-06 7:13 ` Antti Palosaari
2014-08-27 15:29 ` [PATCH v2 5/5] pt3: add support for Earthsoft PT3 ISDB-S/T receiver card tskd08
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=540A88DB.5020306@gmail.com \
--to=tskd08@gmail.com \
--cc=crope@iki.fi \
--cc=linux-media@vger.kernel.org \
--cc=m.chehab@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.