From: Hannes Reinecke <hare@suse.de>
To: Tejun Heo <tj@kernel.org>
Cc: Christoph Hellwig <hch@infradead.org>,
James Bottomley <jbottomley@parallels.com>,
linux-scsi@vger.kernel.org, linux-ide@vger.kernel.org,
Dan Williams <dan.j.williams@intel.com>
Subject: Re: [PATCH 1/4] libata: consolidate ata_dev_classify()
Date: Sun, 07 Sep 2014 13:24:47 +0200 [thread overview]
Message-ID: <540C407F.5030305@suse.de> (raw)
In-Reply-To: <20140906125227.GA29401@mtj.dyndns.org>
On 09/06/2014 02:52 PM, Tejun Heo wrote:
> Hello,
>
> On Sat, Sep 06, 2014 at 10:21:51AM +0200, Hannes Reinecke wrote:
>> Well, yes, in principle. I was looking into that, too.
>> But then I figured that moving to ata_taskfile would be a major overhaul for
>> libsas, which would be quite beyond scope here.
>> And all for a puny little patch.
>
> Hmm? Just allocate a ata_taskfile stuct on stack when invoking the
> function. The change would be a lot smaller actually.
>
Which was actually my first attempt, but then I figured I'd be
increasing the stacksize in doing so.
But sure, if you're okay with it I'll be redoing the patch.
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
hare@suse.de +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)
next prev parent reply other threads:[~2014-09-07 11:24 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-30 7:55 [PATCHv4 0/4] Initial SMR drive support Hannes Reinecke
2014-07-30 7:55 ` [PATCH 1/4] libata: consolidate ata_dev_classify() Hannes Reinecke
2014-09-05 23:42 ` Tejun Heo
2014-09-06 8:21 ` Hannes Reinecke
2014-09-06 12:52 ` Tejun Heo
2014-09-07 11:24 ` Hannes Reinecke [this message]
2014-09-07 16:02 ` Tejun Heo
2014-07-30 7:55 ` [PATCH 2/4] libata: Implement ATA_DEV_ZAC Hannes Reinecke
2014-07-30 7:55 ` [PATCH 3/4] libata-scsi: Update SATL for ZAC drives Hannes Reinecke
2014-09-05 23:44 ` Tejun Heo
2014-07-30 7:55 ` [PATCH 4/4] sd: Optionally attach to ZBC devices Hannes Reinecke
-- strict thread matches above, loose matches on Subject: below --
2014-07-29 14:45 [PATCHv3 0/4] Initial SMR drive support Hannes Reinecke
2014-07-29 14:45 ` [PATCH 1/4] libata: consolidate ata_dev_classify() Hannes Reinecke
2014-07-21 8:27 [PATCHv2 0/4] Initial SMR drive support Hannes Reinecke
2014-07-21 8:27 ` [PATCH 1/4] libata: consolidate ata_dev_classify() Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=540C407F.5030305@suse.de \
--to=hare@suse.de \
--cc=dan.j.williams@intel.com \
--cc=hch@infradead.org \
--cc=jbottomley@parallels.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.