From: Eric Sandeen <sandeen@sandeen.net>
To: xfs@oss.sgi.com
Subject: [PATCH 6/5] xfs_repair: don't re-add root dotdot if root dir was rebuilt
Date: Sun, 07 Sep 2014 12:02:10 -0500 [thread overview]
Message-ID: <540C8F92.5050704@sandeen.net> (raw)
In-Reply-To: <1410108065-18156-1-git-send-email-sandeen@redhat.com>
If we've rebuilt the root directory, ".." was taken
care of, so clear need_root_dotdot.
Otherwise it will be added twice, and a subsequent repair
will say:
entry ".." (ino 5824) in dir 5824 is a duplicate name, would junk entry
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---
(sorry for 6/5, this just popped out and is similar to the
patch 3/5 I just sent, so probably worth doing at the same time.
diff --git a/repair/phase6.c b/repair/phase6.c
index cc36a9c..2e67c60 100644
--- a/repair/phase6.c
+++ b/repair/phase6.c
@@ -2294,6 +2297,9 @@ out_fix:
*/
if (*need_dot)
add_inode_ref(irec, ino_offset);
+ /* If we rebuilt the root dir, dot dot is in good shape */
+ if (ino == mp->m_sb.sb_rootino)
+ need_root_dotdot = 0;
*num_illegal = 0;
*need_dot = 0;
} else {
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2014-09-07 17:02 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-07 16:41 [PATCH 0/5] xfs_repair fixes, part 1 Eric Sandeen
2014-09-07 16:41 ` [PATCH 1/5] xfs_repair: clear bad flgs in process_dinode_int Eric Sandeen
2014-09-08 13:45 ` Brian Foster
2014-09-09 22:28 ` Christoph Hellwig
2014-09-09 22:33 ` Eric Sandeen
2014-09-09 23:48 ` Dave Chinner
2014-09-07 16:41 ` [PATCH 2/5] xfs_repair: preserve error state in process_shortform_attr Eric Sandeen
2014-09-08 13:45 ` Brian Foster
2014-09-09 22:29 ` Christoph Hellwig
2014-09-07 16:41 ` [PATCH 3/5] xfs_repair: fix dir refcount when '.' missing and dir is rebuilt Eric Sandeen
2014-09-08 13:45 ` Brian Foster
2014-09-08 14:25 ` Brian Foster
2014-09-08 14:44 ` Eric Sandeen
2014-09-08 14:33 ` Eric Sandeen
2014-09-07 16:41 ` [PATCH 4/5] xfs_repair: don't ASSERT on corrupt ftype Eric Sandeen
2014-09-08 0:10 ` Dave Chinner
2014-09-08 1:02 ` Eric Sandeen
2014-09-08 3:16 ` Dave Chinner
2014-09-08 3:18 ` Eric Sandeen
2014-09-08 6:23 ` Dave Chinner
2014-09-07 16:41 ` [PATCH 5/5] xfs_repair: set proper ftype when moving to lost+found Eric Sandeen
2014-09-07 21:26 ` Eric Sandeen
2014-09-07 17:02 ` Eric Sandeen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=540C8F92.5050704@sandeen.net \
--to=sandeen@sandeen.net \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.