From mboxrd@z Thu Jan 1 00:00:00 1970 From: Grigori Goronzy Subject: Re: [PATCH] drm/radeon: fix semaphore value init Date: Sun, 07 Sep 2014 19:41:44 +0200 Message-ID: <540C98D8.1020500@chown.ath.cx> References: <1410084412-2541-1-git-send-email-deathsimple@vodafone.de> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1616572188==" Return-path: Received: from pygmy.kinoho.net (pygmy.kinoho.net [134.0.27.24]) by gabe.freedesktop.org (Postfix) with ESMTP id 8896F6E03A for ; Sun, 7 Sep 2014 10:41:49 -0700 (PDT) In-Reply-To: <1410084412-2541-1-git-send-email-deathsimple@vodafone.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: =?UTF-8?B?Q2hyaXN0aWFuIEvDtm5pZw==?= , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --===============1616572188== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="tpMMUQ89n8W1Eec1x3iSuoVTtiSFT6Owg" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --tpMMUQ89n8W1Eec1x3iSuoVTtiSFT6Owg Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 07.09.2014 12:06, Christian K=C3=B6nig wrote: > From: Christian K=C3=B6nig >=20 > Semaphore values have 64 bits, not 32. This fixes a very subtle bug > that disables synchronization when the upper 32bits wasn't zero. > So essentially, half the semaphore values were never properly initialized and some loads with a lot of semaphore synchronization going on tried to use the uninitialized semaphores. I think the description in the commit could be improved according to that. I didn't get any DMA L2T copy hangs with semaphores disabled completely, but unfortunately this doesn't fix the hangs. Anyway, Reviewed-By: Grigori Goronzy Grigori > Signed-off-by: Christian K=C3=B6nig > Cc: stable@vger.kernel.org > --- > drivers/gpu/drm/radeon/radeon_semaphore.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/gpu/drm/radeon/radeon_semaphore.c b/drivers/gpu/dr= m/radeon/radeon_semaphore.c > index 56d9fd6..abd6753 100644 > --- a/drivers/gpu/drm/radeon/radeon_semaphore.c > +++ b/drivers/gpu/drm/radeon/radeon_semaphore.c > @@ -34,7 +34,7 @@ > int radeon_semaphore_create(struct radeon_device *rdev, > struct radeon_semaphore **semaphore) > { > - uint32_t *cpu_addr; > + uint64_t *cpu_addr; > int i, r; > =20 > *semaphore =3D kmalloc(sizeof(struct radeon_semaphore), GFP_KERNEL); >=20 --tpMMUQ89n8W1Eec1x3iSuoVTtiSFT6Owg Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJUDJjYAAoJEOpmYE8Sf8H2y+cP/iUWHqoXNM207VCrHgDv/8+J LCDVuTIei9mJNDaGIep9PC3beg59Oijjz/PGXuCpL5JYxrqMu18KXfyiXPdp1sNH 3Z6dYwv6rpLZ/08WZse0fByVmFf50K/SXU8zpi7DEIcvjYZ3uWxbRO1z+Hbqgxc5 IZiJAH7IdcMNEv7L9R1Xn9jRTVxB5w4k5QnqkIPoibKCxTqBRaYqFEgkI+GgeQNo eg4pklfzhbqWFUaH4/aLuFhVur4BCvH9cHY18W6FXCbSXXMg3xDp1qkUGbM0r1wR 6vmaTV1VctfqmvTLKgSR4KJOVI8HnT9NcWkMJe9jryS1+c8qkzpya/TXsJ10mTaC 2GvbxOm6+gM574DKYjvfypo0JymvjBU1mntUfvhvsVh5VdrcCrVtdQGwXlNR/YpY Fy/SbMz087doCKfAs8pTXQdG+vLfDfhE1ZY49EASFt3C902gsdedP5XFcd5Bd0Zn QGLbV6I5ugbXhMgsQs40QxptLBv63s3BIhEJ6Scrae2QftV/hM3j+fDzqVqgYshP AUv/l3fvRoyE2LSgMxoe1psC1mIyWaQ9aF2fgTkBQAl1JHT8aEePcmfGv0yPGgtf Qlpy9fOXfLI+xBgQ1nTYMHljB2uh040XeYP1ZyPMc6aShqibA2J2iu8K1hfYMR5z 3UmnClUkOiUDkTNJ6116 =poqp -----END PGP SIGNATURE----- --tpMMUQ89n8W1Eec1x3iSuoVTtiSFT6Owg-- --===============1616572188== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel --===============1616572188==--